linux-kernel - Re: [PATCH v26 22/33] ASoC: qcom: qdsp6: Add headphone jack for offload connection status

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <39e1e90e-116c-4f13-b223-84e6991c8a32@linux.intel.com>
Date: Fri, 30 Aug 2024 11:27:02 +0200
From: Pierre-Louis Bossart <pierre-louis.bossart@...ux.intel.com>
To: Wesley Cheng <quic_wcheng@...cinc.com>, srinivas.kandagatla@...aro.org,
 mathias.nyman@...el.com, perex@...ex.cz, conor+dt@...nel.org,
 dmitry.torokhov@...il.com, corbet@....net, broonie@...nel.org,
 lgirdwood@...il.com, tiwai@...e.com, krzk+dt@...nel.org,
 Thinh.Nguyen@...opsys.com, bgoswami@...cinc.com, robh@...nel.org,
 gregkh@...uxfoundation.org
Cc: linux-kernel@...r.kernel.org, devicetree@...r.kernel.org,
 linux-sound@...r.kernel.org, linux-input@...r.kernel.org,
 linux-usb@...r.kernel.org, linux-arm-msm@...r.kernel.org,
 linux-doc@...r.kernel.org, alsa-devel@...a-project.org
Subject: Re: [PATCH v26 22/33] ASoC: qcom: qdsp6: Add headphone jack for
 offload connection status



>  		/* Selects the latest USB headset plugged in for offloading */
> +		if (data->hs_jack && list_empty(&data->devices))
> +			snd_jack_report(data->hs_jack->jack, SND_JACK_USB);
> +

with the list_empty check, this looks like only the first connected
headset will be handled, not the last?

>  		list_add_tail(&sdev->list, &data->devices);
>  	} else {
>  		list_del(&sdev->list);
> +
> +		if (data->hs_jack && list_empty(&data->devices))
> +			snd_jack_report(data->hs_jack->jack, 0);
>  	}
>  	mutex_unlock(&data->mutex);
>  
>  	return 0;
>  }