lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <e7955dd7-95b1-4999-a2a1-519e8d7297a6@linux.intel.com>
Date: Fri, 30 Aug 2024 11:52:55 +0200
From: Pierre-Louis Bossart <pierre-louis.bossart@...ux.intel.com>
To: Wesley Cheng <quic_wcheng@...cinc.com>, srinivas.kandagatla@...aro.org,
 mathias.nyman@...el.com, perex@...ex.cz, conor+dt@...nel.org,
 dmitry.torokhov@...il.com, corbet@....net, broonie@...nel.org,
 lgirdwood@...il.com, tiwai@...e.com, krzk+dt@...nel.org,
 Thinh.Nguyen@...opsys.com, bgoswami@...cinc.com, robh@...nel.org,
 gregkh@...uxfoundation.org
Cc: linux-kernel@...r.kernel.org, devicetree@...r.kernel.org,
 linux-sound@...r.kernel.org, linux-input@...r.kernel.org,
 linux-usb@...r.kernel.org, linux-arm-msm@...r.kernel.org,
 linux-doc@...r.kernel.org, alsa-devel@...a-project.org
Subject: Re: [PATCH v26 28/33] ALSA: usb-audio: qcom: Introduce QC USB SND
 offloading support


> +/* Stream disable request timeout during USB device disconnect */
> +#define DEV_RELEASE_WAIT_TIMEOUT 10000 /* in ms */

10s really? That seems rather large for a stream disable timeout...

> +static struct snd_usb_platform_ops offload_ops = {
> +	.connect_cb = qc_usb_audio_offload_probe,
> +	.disconnect_cb = qc_usb_audio_offload_disconnect,
> +	.suspend_cb = qc_usb_audio_offload_suspend,
> +};

You probably want to explain why there's no .resume_cb?

The comments mention also that the suspend_cb has to stop playback, but
then who resumes playback :-)



Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ