linux-kernel - Re: [PATCH v2 1/4] arm64: dts: ti: k3-am65: Include entire FSS region in ranges

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <da3410c9-232a-4044-9ba1-087e8fef7549@ti.com>
Date: Fri, 30 Aug 2024 16:30:07 +0530
From: Santhosh Kumar K <s-k6@...com>
To: Andrew Davis <afd@...com>, Nishanth Menon <nm@...com>,
        Vignesh Raghavendra
	<vigneshr@...com>,
        Tero Kristo <kristo@...nel.org>, Rob Herring
	<robh+dt@...nel.org>,
        Krzysztof Kozlowski
	<krzysztof.kozlowski+dt@...aro.org>,
        Conor Dooley <conor+dt@...nel.org>
CC: <linux-arm-kernel@...ts.infradead.org>, <devicetree@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 1/4] arm64: dts: ti: k3-am65: Include entire FSS region
 in ranges

Hi, Andrew,

On 28/08/24 22:59, Andrew Davis wrote:
> Add FSS regions at 0x50000000, 0x400000000, and 0x600000000. Although
> not used currently by the Linux FSS driver, these regions belong to
> the FSS and should be included in the ranges mapping.
> 
> While here, a couple of these numbers had missing zeros which was
> hidden by odd alignments, fix both these issues.
> 
> Signed-off-by: Andrew Davis <afd@...com>
> Reviewed-by: Santhosh Kumar K <s-k6@...com>
> ---
>   arch/arm64/boot/dts/ti/k3-am65-mcu.dtsi |  8 ++++----
>   arch/arm64/boot/dts/ti/k3-am65.dtsi     | 12 +++++-------
>   2 files changed, 9 insertions(+), 11 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/ti/k3-am65-mcu.dtsi b/arch/arm64/boot/dts/ti/k3-am65-mcu.dtsi
> index 43c6118d2bf0f..1a251d13f80ab 100644
> --- a/arch/arm64/boot/dts/ti/k3-am65-mcu.dtsi
> +++ b/arch/arm64/boot/dts/ti/k3-am65-mcu.dtsi
> @@ -292,13 +292,13 @@ fss: bus@...00000 {
>   		ranges = <0x0 0x47000000 0x0 0x47000000 0x0 0x100>, /* FSS Control */
>   			 <0x0 0x47040000 0x0 0x47040000 0x0 0x100>, /* OSPI0 Control */
>   			 <0x0 0x47050000 0x0 0x47050000 0x0 0x100>, /* OSPI1 Control */
> -			 <0x5 0x00000000 0x5 0x00000000 0x1 0x0000000>, /* OSPI0 Memory */
> -			 <0x7 0x00000000 0x7 0x00000000 0x1 0x0000000>; /* OSPI1 Memory */
> +			 <0x0 0x50000000 0x0 0x50000000 0x0 0x10000000>, /* FSS data region 1 */
> +			 <0x4 0x00000000 0x4 0x00000000 0x4 0x00000000>; /* FSS data region 0/3 */
>   
>   		ospi0: spi@...40000 {
>   			compatible = "ti,am654-ospi", "cdns,qspi-nor";
>   			reg = <0x0 0x47040000 0x0 0x100>,
> -				<0x5 0x00000000 0x1 0x0000000>;
> +			      <0x5 0x00000000 0x1 0x00000000>;
>   			interrupts = <GIC_SPI 552 IRQ_TYPE_LEVEL_HIGH>;
>   			cdns,fifo-depth = <256>;
>   			cdns,fifo-width = <4>;
> @@ -316,7 +316,7 @@ ospi0: spi@...40000 {
>   		ospi1: spi@...50000 {
>   			compatible = "ti,am654-ospi", "cdns,qspi-nor";
>   			reg = <0x0 0x47050000 0x0 0x100>,
> -				<0x7 0x00000000 0x1 0x00000000>;
> +			      <0x7 0x00000000 0x1 0x00000000>;
>   			interrupts = <GIC_SPI 553 IRQ_TYPE_LEVEL_HIGH>;
>   			cdns,fifo-depth = <256>;
>   			cdns,fifo-width = <4>;
> diff --git a/arch/arm64/boot/dts/ti/k3-am65.dtsi b/arch/arm64/boot/dts/ti/k3-am65.dtsi
> index c59baebc5a25b..c74a0a25832cb 100644
> --- a/arch/arm64/boot/dts/ti/k3-am65.dtsi
> +++ b/arch/arm64/boot/dts/ti/k3-am65.dtsi
> @@ -69,11 +69,10 @@ cbass_main: bus@...000 {
>   			 <0x00 0x45100000 0x00 0x45100000 0x00 0x00c24000>,
>   			 <0x00 0x46000000 0x00 0x46000000 0x00 0x00200000>,
>   			 <0x00 0x47000000 0x00 0x47000000 0x00 0x00068400>,
> -			 <0x00 0x50000000 0x00 0x50000000 0x00 0x8000000>,
> +			 <0x00 0x50000000 0x00 0x50000000 0x00 0x10000000>,
>   			 <0x00 0x6f000000 0x00 0x6f000000 0x00 0x00310000>, /* A53 PERIPHBASE */
> -			 <0x00 0x70000000 0x00 0x70000000 0x00 0x200000>,
> -			 <0x05 0x00000000 0x05 0x00000000 0x01 0x0000000>,
> -			 <0x07 0x00000000 0x07 0x00000000 0x01 0x0000000>;
> +			 <0x00 0x70000000 0x00 0x70000000 0x00 0x00200000>,
> +			 <0x04 0x00000000 0x04 0x00000000 0x04 0x00000000>;

Suggested changes have been added, thanks!

Acked-by: Santhosh Kumar K <s-k6@...com>

>   
>   		cbass_mcu: bus@...80000 {
>   			compatible = "simple-bus";
> @@ -89,9 +88,8 @@ cbass_mcu: bus@...80000 {
>   				 <0x00 0x45100000 0x00 0x45100000 0x00 0x00c24000>, /* MMRs, remaining NAVSS */
>   				 <0x00 0x46000000 0x00 0x46000000 0x00 0x00200000>, /* CPSW */
>   				 <0x00 0x47000000 0x00 0x47000000 0x00 0x00068400>, /* OSPI space 1 */
> -				 <0x00 0x50000000 0x00 0x50000000 0x00 0x8000000>, /*  FSS OSPI0 data region 1 */
> -				 <0x05 0x00000000 0x05 0x00000000 0x01 0x0000000>, /* FSS OSPI0 data region 3*/
> -				 <0x07 0x00000000 0x07 0x00000000 0x01 0x0000000>; /* FSS OSPI1 data region 3*/
> +				 <0x00 0x50000000 0x00 0x50000000 0x00 0x10000000>, /* FSS data region 1 */
> +				 <0x04 0x00000000 0x04 0x00000000 0x04 0x00000000>; /* FSS data region 0/3 */
>   
>   			cbass_wakeup: bus@...40000 {
>   				compatible = "simple-bus";