linux-kernel - Re: [PATCH] arm64: dts: ti: k3-am68-sk-som: Update Partition info for OSPI Flash

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240830112452.geyv7tecpb6ydhmz@quotable>
Date: Fri, 30 Aug 2024 06:24:52 -0500
From: Nishanth Menon <nm@...com>
To: Prasanth Babu Mantena <p-mantena@...com>
CC: <vigneshr@...com>, <krzk+dt@...nel.org>, <kristo@...nel.org>,
        <robh@...nel.org>, <conor+dt@...nel.org>,
        <linux-arm-kernel@...ts.infradead.org>, <devicetree@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, <u-kumar1@...com>,
        <sinthu.raja@...com>, <m-chawdhry@...com>
Subject: Re: [PATCH] arm64: dts: ti: k3-am68-sk-som: Update Partition info
 for OSPI Flash

On 11:38-20240828, Prasanth Babu Mantena wrote:
> Commit 73f1f26e2e4c ("arm64: dts: ti: k3-am68-sk-som: Add support
> for OSPI flash") introduced the flash node with discontinuous
> partitions. Updating the partition offset to be continuous from
> the previous partition to maintain linearity.
> 
> Signed-off-by: Prasanth Babu Mantena <p-mantena@...com>
> ---

Please note my response to a similar patch
https://lore.kernel.org/all/20240830092234.veog3e22te7qi3ao@dugout/

I do not want us breaking existing users unless absolutely warranted,
even then, I'd like us to be very cognizant of the minimum amount of
disruption possible.

Normally, I'd say no to this kind of patches. But, since this is in
the backup env, I am not *that* worried, but I want to make sure folks
understand breaking existing users without a just cause is a NO NO.

>  arch/arm64/boot/dts/ti/k3-am68-sk-som.dtsi | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/ti/k3-am68-sk-som.dtsi b/arch/arm64/boot/dts/ti/k3-am68-sk-som.dtsi
> index 5c66e0ec6e82..2e5730216caa 100644
> --- a/arch/arm64/boot/dts/ti/k3-am68-sk-som.dtsi
> +++ b/arch/arm64/boot/dts/ti/k3-am68-sk-som.dtsi
> @@ -215,9 +215,9 @@ partition@...000 {
>  				reg = <0x680000 0x40000>;
>  			};
>  
> -			partition@...000 {
> +			partition@...000 {
>  				label = "ospi.env.backup";
> -				reg = <0x740000 0x40000>;
> +				reg = <0x6c0000 0x40000>;
>  			};
>  
>  			partition@...000 {
> -- 
> 2.34.1
> 

-- 
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D