linux-kernel - Re: [syzbot] [iomap?] [xfs?] WARNING in iomap_write

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20240830113130.165574-1-sunjunchao2870@gmail.com>
Date: Fri, 30 Aug 2024 19:31:30 +0800
From: Julian Sun <sunjunchao2870@...il.com>
To: sunjunchao2870@...il.com
Cc: brauner@...nel.org,
	chandan.babu@...cle.com,
	djwong@...nel.org,
	linux-fsdevel@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	linux-xfs@...r.kernel.org,
	syzbot+296b1c84b9cbf306e5a0@...kaller.appspotmail.com,
	syzkaller-bugs@...glegroups.com
Subject: Re: [syzbot] [iomap?] [xfs?] WARNING in iomap_write_begin

The patch passed test locally, and the patch in the link 
appears to be messed up. Please retest.

#syz test: upstream ee9a43b7cfe2

diff --git a/fs/xfs/xfs_iomap.c b/fs/xfs/xfs_iomap.c
index 72c981e3dc92..6216c31aa3cc 100644
--- a/fs/xfs/xfs_iomap.c
+++ b/fs/xfs/xfs_iomap.c
@@ -1162,6 +1162,9 @@ xfs_buffered_write_iomap_begin(
 	if (error)
 		goto out_unlock;
 
+	/* Get extent info that may updated by xfs_bmapi_reserve_delalloc() */
+	xfs_iext_lookup_extent(ip, &ip->i_df, offset_fsb, &icur, &imap);
+
 	/*
 	 * Flag newly allocated delalloc blocks with IOMAP_F_NEW so we punch
 	 * them out if the write happens to fail.