[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <076a7814-1ab9-a6a1-6b08-3f414595c6ba@linux.intel.com>
Date: Fri, 30 Aug 2024 15:23:28 +0300 (EEST)
From: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
To: Bjorn Helgaas <bhelgaas@...gle.com>
cc: linux-pci@...r.kernel.org, Mahesh J Salgaonkar <mahesh@...ux.ibm.com>,
Oliver O'Halloran <oohall@...il.com>, Lukas Wunner <lukas@...ner.de>,
linuxppc-dev@...ts.ozlabs.org, LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v5 0/7] PCI: Consolidate TLP Log reading and printing
On Tue, 14 May 2024, Ilpo Järvinen wrote:
> This series has the remaining patches of the AER & DPC TLP Log handling
> consolidation and now includes a few minor improvements to the earlier
> accepted TLP Logging code.
>
> v5:
> - Fix build with AER=y and DPC=n
> - Match kerneldoc and function parameter name
Hi Bjorn,
A gentle reminder, could you take a look at this series (and perhaps also
the one which introduces the Flit mode support on top of this series).
--
i.
> v4:
> - Added patches:
> - Remove EXPORT of pcie_read_tlp_log()
> - Moved code to pcie/tlp.c and build only with AER enabled
> - Match variables in prototype and function
> - int -> unsigned int conversion
> - eetlp_prefix_max into own patch
> - struct pcie_tlp_log param consistently called "log" within tlp.c
> - Moved function prototypes into drivers/pci/pci.h
> - Describe AER/DPC differences more clearly in one commit message
>
> v3:
> - Small rewording in a commit message
>
> v2:
> - Don't add EXPORT()s
> - Don't include igxbe changes
> - Don't use pr_cont() as it's incompatible with pci_err() and according
> to Andy Shevchenko should not be used in the first place
>
> Ilpo Järvinen (7):
> PCI: Don't expose pcie_read_tlp_log() outside of PCI subsystem
> PCI: Move TLP Log handling to own file
> PCI: Make pcie_read_tlp_log() signature same
> PCI: Use unsigned int i in pcie_read_tlp_log()
> PCI: Store # of supported End-End TLP Prefixes
> PCI: Add TLP Prefix reading into pcie_read_tlp_log()
> PCI: Create helper to print TLP Header and Prefix Log
>
> drivers/pci/ats.c | 2 +-
> drivers/pci/pci.c | 28 ---------
> drivers/pci/pci.h | 9 +++
> drivers/pci/pcie/Makefile | 2 +-
> drivers/pci/pcie/aer.c | 14 ++---
> drivers/pci/pcie/dpc.c | 14 ++---
> drivers/pci/pcie/tlp.c | 109 ++++++++++++++++++++++++++++++++++
> drivers/pci/probe.c | 14 +++--
> include/linux/aer.h | 3 +-
> include/linux/pci.h | 2 +-
> include/uapi/linux/pci_regs.h | 2 +
> 11 files changed, 143 insertions(+), 56 deletions(-)
> create mode 100644 drivers/pci/pcie/tlp.c
>
>
Powered by blists - more mailing lists