linux-kernel - [PATCH v2] selftests: splice: Add usage() to splice

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <tencent_0AEA8FB622DE1A740841643D5F36ABF8BD0A@qq.com>
Date: Sat, 31 Aug 2024 13:14:28 +0800
From: Rong Tao <rtoax@...mail.com>
To: shuah@...nel.org
Cc: rongtao@...tc.cn,
	Rong Tao <rtoax@...mail.com>,
	linux-kselftest@...r.kernel.org (open list:KERNEL SELFTEST FRAMEWORK),
	linux-kernel@...r.kernel.org (open list)
Subject: [PATCH v2] selftests: splice: Add usage() to splice_read.c

From: Rong Tao <rongtao@...tc.cn>

Give the programmer more help information to inform the program on how to
use it.

Signed-off-by: Rong Tao <rongtao@...tc.cn>
---
 tools/testing/selftests/splice/splice_read.c | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/tools/testing/selftests/splice/splice_read.c b/tools/testing/selftests/splice/splice_read.c
index 46dae6a25cfb..73a8bc146f97 100644
--- a/tools/testing/selftests/splice/splice_read.c
+++ b/tools/testing/selftests/splice/splice_read.c
@@ -9,6 +9,12 @@
 #include <sys/types.h>
 #include <sys/stat.h>
 
+void usage(const char *prog)
+{
+	fprintf(stderr, "Usage: %s INPUT [BYTES]\n", prog);
+	fprintf(stderr, "       %s /etc/os-release | cat\n", prog);
+}
+
 int main(int argc, char *argv[])
 {
 	int fd;
@@ -16,7 +22,7 @@ int main(int argc, char *argv[])
 	ssize_t spliced;
 
 	if (argc < 2) {
-		fprintf(stderr, "Usage: %s INPUT [BYTES]\n", argv[0]);
+		usage(argv[0]);
 		return EXIT_FAILURE;
 	}
 
@@ -49,6 +55,7 @@ int main(int argc, char *argv[])
 		      size, SPLICE_F_MOVE);
 	if (spliced < 0) {
 		perror("splice");
+		usage(argv[0]);
 		return EXIT_FAILURE;
 	}
 
-- 
2.46.0