linux-kernel - Re: [PATCH] selftests: splice: Add splice

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <tencent_6184E8B23A2EFF54CC5F2346B7105F0C8209@qq.com>
Date: Sat, 31 Aug 2024 13:25:21 +0800
From: Rong Tao <rtoax@...mail.com>
To: Shuah Khan <skhan@...uxfoundation.org>, shuah@...nel.org
Cc: rongtao@...tc.cn, open list <linux-kernel@...r.kernel.org>,
 "open list:KERNEL SELFTEST FRAMEWORK" <linux-kselftest@...r.kernel.org>
Subject: Re: [PATCH] selftests: splice: Add splice_read.sh and hint


On 8/30/24 8:37 PM, Shuah Khan wrote:
> On 8/27/24 21:40, Rong Tao wrote:
>> From: Rong Tao <rongtao@...tc.cn>
>>
>> Add test scripts and prompts.
>
> Can you give more details on what these scripts and prompts do?
>
I just push 
v2(https://lore.kernel.org/lkml/tencent_0AEA8FB622DE1A740841643D5F36ABF8BD0A@qq.com/)

At the first time, I just want to do the same thing that 
default_file_splice_read.sh did,

and splice_read.sh looks like useless, i just remove splice_read.sh in v2.

>>
>> Signed-off-by: Rong Tao <rongtao@...tc.cn>
>> ---
>>   tools/testing/selftests/splice/splice_read.c  | 1 +
>>   tools/testing/selftests/splice/splice_read.sh | 9 +++++++++
>>   2 files changed, 10 insertions(+)
>>   create mode 100755 tools/testing/selftests/splice/splice_read.sh
>>
>> diff --git a/tools/testing/selftests/splice/splice_read.c 
>> b/tools/testing/selftests/splice/splice_read.c
>> index 46dae6a25cfb..194b075f6bc0 100644
>> --- a/tools/testing/selftests/splice/splice_read.c
>> +++ b/tools/testing/selftests/splice/splice_read.c
>> @@ -49,6 +49,7 @@ int main(int argc, char *argv[])
>>                 size, SPLICE_F_MOVE);
>>       if (spliced < 0) {
>>           perror("splice");
>> +        fprintf(stderr, "May try: %s /etc/os-release | cat\n", 
>> argv[0]);
>
> Is this supposed to be usage or help message?

Yes, I just add usage() function to splice_read.c in 
v2(https://lore.kernel.org/lkml/tencent_0AEA8FB622DE1A740841643D5F36ABF8BD0A@qq.com/)

Please review, thanks.

>
>>           return EXIT_FAILURE;
>>       }
>>   diff --git a/tools/testing/selftests/splice/splice_read.sh 
>> b/tools/testing/selftests/splice/splice_read.sh
>> new file mode 100755
>> index 000000000000..10fd5d738a2d
>> --- /dev/null
>> +++ b/tools/testing/selftests/splice/splice_read.sh
>> @@ -0,0 +1,9 @@
>> +#!/bin/sh
>> +# SPDX-License-Identifier: GPL-2.0
>> +set -e
>> +nl=$(./splice_read /etc/os-release | wc -l)
>> +
>> +test "$nl" != 0 && exit 0
>> +
>> +echo "splice_read broken"
>> +exit 1
>
> thanks,
> -- Shuah

Thank you.

Rong Tao