linux-kernel - Re: [PATCH v1] hwmon: (sht15) Simplify with dev_err

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4792cf2f-1a53-428b-9760-9f8c506c34d7@kernel.org>
Date: Sat, 31 Aug 2024 07:53:14 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Shen Lichuan <shenlichuan@...o.com>, jdelvare@...e.com, linux@...ck-us.net
Cc: linux-hwmon@...r.kernel.org, linux-kernel@...r.kernel.org,
 opensource.kernel@...o.com
Subject: Re: [PATCH v1] hwmon: (sht15) Simplify with dev_err_probe()

On 30/08/2024 08:54, Shen Lichuan wrote:
> Use dev_err_probe() to simplify the error path and unify a message
> template.
> 
> Using this helper is totally fine even if err is known to never
> be -EPROBE_DEFER.
> 
> The benefit compared to a normal dev_err() is the standardized format
> of the error code, it being emitted symbolically and the fact that
> the error code is returned which allows more compact error paths.
> 
> Signed-off-by: Shen Lichuan <shenlichuan@...o.com>
> ---
>  drivers/hwmon/sht15.c | 8 +++-----
>  1 file changed, 3 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/hwmon/sht15.c b/drivers/hwmon/sht15.c
> index 494f9655f44f..cc3a46a9c68e 100644
> --- a/drivers/hwmon/sht15.c
> +++ b/drivers/hwmon/sht15.c
> @@ -942,11 +942,9 @@ static int sht15_probe(struct platform_device *pdev)
>  			data->supply_uv = voltage;
>  
>  		ret = regulator_enable(data->reg);
> -		if (ret != 0) {
> -			dev_err(&pdev->dev,
> -				"failed to enable regulator: %d\n", ret);
> -			return ret;
> -		}
> +		if (ret != 0)
> +			return dev_err_probe(&pdev->dev, ret,
> +					     "failed to enable regulator\n");

This is ridiculous patch created by some low quality automation without
any review and thoughts from vivo.com side.

You change something which cannot defer, while leaving out unchanged
other places which actually can defer and could benefit.

Stop spamming with such low quality patches.

Best regards,
Krzysztof