linux-kernel - Re: [PATCH v2 2/4] irqchip/apple-aic: Skip unnecessary setting of use_fast

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <05775A47-1FA8-47BF-9449-351CB35B9A42@svenpeter.dev>
Date: Sat, 31 Aug 2024 08:48:23 +0200
From: Sven Peter <sven@...npeter.dev>
To: Nick Chan <towinchenmi@...il.com>
Cc: Hector Martin <marcan@...can.st>,
 Alyssa Rosenzweig <alyssa@...enzweig.io>,
 Thomas Gleixner <tglx@...utronix.de>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>, asahi@...ts.linux.dev,
 linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
 devicetree@...r.kernel.org, konrad.dybcio@...ainline.org,
 ~postmarketos/upstreaming@...ts.sr.ht
Subject: Re: [PATCH v2 2/4] irqchip/apple-aic: Skip unnecessary setting of use_fast_ipi



> On 31. Aug 2024, at 07:57, Nick Chan <towinchenmi@...il.com> wrote:
> 
> use_fast_ipi is true by default and there is no need to "enable" it.
> 
> Signed-off-by: Nick Chan <towinchenmi@...il.com>
> ---

Acked-by: Sven Peter <sven@...npeter.dev>


> drivers/irqchip/irq-apple-aic.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/irqchip/irq-apple-aic.c b/drivers/irqchip/irq-apple-aic.c
> index 5c534d9fd2b0..8d81d5fb3c50 100644
> --- a/drivers/irqchip/irq-apple-aic.c
> +++ b/drivers/irqchip/irq-apple-aic.c
> @@ -987,9 +987,7 @@ static int __init aic_of_ic_init(struct device_node *node, struct device_node *p
>    off += sizeof(u32) * (irqc->max_irq >> 5); /* MASK_CLR */
>    off += sizeof(u32) * (irqc->max_irq >> 5); /* HW_STATE */
> 
> -    if (irqc->info.fast_ipi)
> -        static_branch_enable(&use_fast_ipi);
> -    else
> +    if (!irqc->info.fast_ipi)
>        static_branch_disable(&use_fast_ipi);
> 
>    irqc->info.die_stride = off - start_off;
> --
> 2.46.0
>