linux-kernel - Re: [PATCH v5] LoongArch: vDSO: Wire up getrandom() vDSO implementation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <302f203a-088c-431f-beef-86b10ae9b284@csgroup.eu>
Date: Sat, 31 Aug 2024 10:54:14 +0200
From: Christophe Leroy <christophe.leroy@...roup.eu>
To: Huacai Chen <chenhuacai@...nel.org>, Xi Ruoyao <xry111@...111.site>
Cc: "Jason A . Donenfeld" <Jason@...c4.com>, WANG Xuerui <kernel@...0n.name>,
 linux-crypto@...r.kernel.org, loongarch@...ts.linux.dev,
 linux-kernel@...r.kernel.org, Jinyang He <hejinyang@...ngson.cn>,
 Tiezhu Yang <yangtiezhu@...ngson.cn>, Arnd Bergmann <arnd@...db.de>,
 Thomas Gleixner <tglx@...utronix.de>,
 Christophe Leroy <christophe.leroy@...roup.eu>
Subject: Re: [PATCH v5] LoongArch: vDSO: Wire up getrandom() vDSO
 implementation

Le 31/08/2024 à 09:10, Huacai Chen a écrit :
> [Vous ne recevez pas souvent de courriers de chenhuacai@...nel.org. Découvrez pourquoi ceci est important à https://aka.ms/LearnAboutSenderIdentification ]
> 
> On Sat, Aug 31, 2024 at 2:40 PM Xi Ruoyao <xry111@...111.site> wrote:
>>
>> On Thu, 2024-08-29 at 21:18 +0800, Huacai Chen wrote:
>>>> -obj-vdso-y := elf.o vgetcpu.o vgettimeofday.o sigreturn.o
>>>> +obj-vdso-y := elf.o vgetcpu.o vgettimeofday.o sigreturn.o vgetrandom.o \
>>>> +              vgetrandom-chacha.o
>>
>> Huacai: do you prefer to remove this line break as well, or Makefile
>> still has a line width limit?
> Also no limit, but Makefile is more or less different because there is
> no "statement" and doesn't affect our understanding.
> 
> So, line break is fine here (but for my own preference I like to keep
> sigreturn.o at last).

To avoid line break you can leave the first line unmodified and add:

obj-vdso-y += vgetrandom.o vgetrandom-chacha.o

Christophe