linux-kernel - Re: [PATCH] docs: scheduler: completion: Update member of struct completion

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZtLeCc4GeZbwiJZ9@visitorckw-System-Product-Name>
Date: Sat, 31 Aug 2024 17:10:33 +0800
From: Kuan-Wei Chiu <visitorckw@...il.com>
To: I Hsin Cheng <richard120310@...il.com>
Cc: corbet@....net, linux-doc@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] docs: scheduler: completion: Update member of struct
 completion

On Thu, Aug 29, 2024 at 12:50:36AM +0800, I Hsin Cheng wrote:
> The member "wait" in struct completion isn't of type wait_queue_head_t
> anymore, as it is now "struct swait_queue_head", fix it to match with
> the current implementation.
> 
> Signed-off-by: I Hsin Cheng <richard120310@...il.com>

LGTM. Feel free to add:

Reviewed-by: Kuan-Wei Chiu <visitorckw@...il.com>

> ---
>  Documentation/scheduler/completion.rst | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Documentation/scheduler/completion.rst b/Documentation/scheduler/completion.rst
> index f19aca2062bd..adf0c0a56d02 100644
> --- a/Documentation/scheduler/completion.rst
> +++ b/Documentation/scheduler/completion.rst
> @@ -51,7 +51,7 @@ which has only two fields::
>  
>  	struct completion {
>  		unsigned int done;
> -		wait_queue_head_t wait;
> +		struct swait_queue_head wait;
>  	};
>  
>  This provides the ->wait waitqueue to place tasks on for waiting (if any), and
> -- 
> 2.34.1
>