linux-kernel - Re: [PATCH] iio: adc: mcp320x: Drop vendorless compatible strings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20240831114756.38b459a1@jic23-huawei>
Date: Sat, 31 Aug 2024 11:47:56 +0100
From: Jonathan Cameron <jic23@...nel.org>
To: "Rob Herring (Arm)" <robh@...nel.org>
Cc: Lars-Peter Clausen <lars@...afoo.de>, linux-iio@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH] iio: adc: mcp320x: Drop vendorless compatible strings

On Mon, 26 Aug 2024 14:17:28 -0500
"Rob Herring (Arm)" <robh@...nel.org> wrote:

> The vendorless compatible strings are deprecated and weren't retained
> when the binding was converted to schema. As a result, they are listed
> as undocumented when running "make dt_compatible_check". Rather than add
> them back to the schema, let's just drop them as they are unnecessary.
> Furthermore, they are unnecessary as the SPI matching will strip the
> vendor prefix on compatible string and match that against the
> spi_device_id table.
> 
> Signed-off-by: Rob Herring (Arm) <robh@...nel.org>
Applied.

Thanks,

> ---
>  drivers/iio/adc/mcp320x.c | 10 ----------
>  1 file changed, 10 deletions(-)
> 
> diff --git a/drivers/iio/adc/mcp320x.c b/drivers/iio/adc/mcp320x.c
> index da1421bd7b62..57cff3772ebe 100644
> --- a/drivers/iio/adc/mcp320x.c
> +++ b/drivers/iio/adc/mcp320x.c
> @@ -459,16 +459,6 @@ static int mcp320x_probe(struct spi_device *spi)
>  }
>  
>  static const struct of_device_id mcp320x_dt_ids[] = {
> -	/* NOTE: The use of compatibles with no vendor prefix is deprecated. */
> -	{ .compatible = "mcp3001" },
> -	{ .compatible = "mcp3002" },
> -	{ .compatible = "mcp3004" },
> -	{ .compatible = "mcp3008" },
> -	{ .compatible = "mcp3201" },
> -	{ .compatible = "mcp3202" },
> -	{ .compatible = "mcp3204" },
> -	{ .compatible = "mcp3208" },
> -	{ .compatible = "mcp3301" },
>  	{ .compatible = "microchip,mcp3001" },
>  	{ .compatible = "microchip,mcp3002" },
>  	{ .compatible = "microchip,mcp3004" },