linux-kernel - RE: [PATCH v1] fusion: mptctl: Use min macro

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <27dfad1261db41988d31dbb62af13fc4@AcuMS.aculab.com>
Date: Sat, 31 Aug 2024 12:19:57 +0000
From: David Laight <David.Laight@...LAB.COM>
To: 'Yan Zhen' <yanzhen@...o.com>, "sathya.prakash@...adcom.com"
	<sathya.prakash@...adcom.com>, "sreekanth.reddy@...adcom.com"
	<sreekanth.reddy@...adcom.com>, "suganath-prabu.subramani@...adcom.com"
	<suganath-prabu.subramani@...adcom.com>
CC: "MPT-FusionLinux.pdl@...adcom.com" <MPT-FusionLinux.pdl@...adcom.com>,
	"linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"opensource.kernel@...o.vom" <opensource.kernel@...o.vom>
Subject: RE: [PATCH v1] fusion: mptctl: Use min macro

From: Yan Zhen
> Sent: 27 August 2024 12:39
> 
> Using the real macro is usually more intuitive and readable,
> When the original file is guaranteed to contain the minmax.h header file
> and compile correctly.
> 
> Signed-off-by: Yan Zhen <yanzhen@...o.com>
> ---
>  drivers/message/fusion/mptctl.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/message/fusion/mptctl.c b/drivers/message/fusion/mptctl.c
> index 9f3999750..17798edf7 100644
> --- a/drivers/message/fusion/mptctl.c
> +++ b/drivers/message/fusion/mptctl.c
> @@ -1609,7 +1609,7 @@ mptctl_eventreport (MPT_ADAPTER *ioc, unsigned long arg)
>  	maxEvents = numBytes/sizeof(MPT_IOCTL_EVENTS);
> 
> 
> -	max = MPTCTL_EVENT_LOG_SIZE < maxEvents ? MPTCTL_EVENT_LOG_SIZE : maxEvents;
> +	max = min(MPTCTL_EVENT_LOG_SIZE, maxEvents);

IMHO the arguments should be swapped.
	min(variable, CONSTANT);
is better.

	David.

-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)