| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <202408312025.Tjnlxn0W-lkp@intel.com>
Date: Sat, 31 Aug 2024 21:15:28 +0800
From: kernel test robot <lkp@...el.com>
To: Liao Yuanhong <liaoyuanhong@...o.com>, vkoul@...nel.org
Cc: llvm@...ts.linux.dev, oe-kbuild-all@...ts.linux.dev,
dmaengine@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
linux-kernel@...r.kernel.org, imx@...ts.linux.dev,
Liao Yuanhong <liaoyuanhong@...o.com>
Subject: Re: [PATCH v2 1/7] dmaengine:Add COMPILE_TEST for easy testing
Hi Liao,
kernel test robot noticed the following build warnings:
[auto build test WARNING on vkoul-dmaengine/next]
[also build test WARNING on shawnguo/for-next soc/for-next linus/master v6.11-rc5 next-20240830]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Liao-Yuanhong/dmaengine-Add-COMPILE_TEST-for-easy-testing/20240830-174451
base: https://git.kernel.org/pub/scm/linux/kernel/git/vkoul/dmaengine.git next
patch link: https://lore.kernel.org/r/20240830094118.15458-2-liaoyuanhong%40vivo.com
patch subject: [PATCH v2 1/7] dmaengine:Add COMPILE_TEST for easy testing
config: x86_64-allyesconfig (https://download.01.org/0day-ci/archive/20240831/202408312025.Tjnlxn0W-lkp@intel.com/config)
compiler: clang version 18.1.5 (https://github.com/llvm/llvm-project 617a15a9eac96088ae5e9134248d8236e34b91b1)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240831/202408312025.Tjnlxn0W-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202408312025.Tjnlxn0W-lkp@intel.com/
All warnings (new ones prefixed by >>):
>> drivers/dma/at_hdmac.c:891:45: warning: format specifies type 'int' but the argument has type 'size_t' (aka 'unsigned long') [-Wformat]
890 | "%s: src=%pad, dest=%pad, numf=%d, frame_size=%d, flags=0x%lx\n",
| ~~
| %zu
891 | __func__, &xt->src_start, &xt->dst_start, xt->numf,
| ^~~~~~~~
include/linux/dev_printk.h:160:67: note: expanded from macro 'dev_info'
160 | dev_printk_index_wrap(_dev_info, KERN_INFO, dev, dev_fmt(fmt), ##__VA_ARGS__)
| ~~~ ^~~~~~~~~~~
include/linux/dev_printk.h:110:23: note: expanded from macro 'dev_printk_index_wrap'
110 | _p_func(dev, fmt, ##__VA_ARGS__); \
| ~~~ ^~~~~~~~~~~
drivers/dma/at_hdmac.c:892:3: warning: format specifies type 'int' but the argument has type 'size_t' (aka 'unsigned long') [-Wformat]
890 | "%s: src=%pad, dest=%pad, numf=%d, frame_size=%d, flags=0x%lx\n",
| ~~
| %zu
891 | __func__, &xt->src_start, &xt->dst_start, xt->numf,
892 | xt->frame_size, flags);
| ^~~~~~~~~~~~~~
include/linux/dev_printk.h:160:67: note: expanded from macro 'dev_info'
160 | dev_printk_index_wrap(_dev_info, KERN_INFO, dev, dev_fmt(fmt), ##__VA_ARGS__)
| ~~~ ^~~~~~~~~~~
include/linux/dev_printk.h:110:23: note: expanded from macro 'dev_printk_index_wrap'
110 | _p_func(dev, fmt, ##__VA_ARGS__); \
| ~~~ ^~~~~~~~~~~
>> drivers/dma/at_hdmac.c:1178:11: warning: format specifies type 'size_t' (aka 'unsigned long') but the argument has type 'unsigned int' [-Wformat]
1177 | dev_vdbg(chan2dev(chan), "%s: v0x%x l0x%zx f0x%lx\n", __func__,
| ~~~
| %x
1178 | value, sg_len, flags);
| ^~~~~~
include/linux/dev_printk.h:261:18: note: expanded from macro 'dev_vdbg'
261 | #define dev_vdbg dev_dbg
| ^
include/linux/dev_printk.h:165:39: note: expanded from macro 'dev_dbg'
165 | dynamic_dev_dbg(dev, dev_fmt(fmt), ##__VA_ARGS__)
| ~~~ ^~~~~~~~~~~
include/linux/dynamic_debug.h:274:19: note: expanded from macro 'dynamic_dev_dbg'
274 | dev, fmt, ##__VA_ARGS__)
| ~~~ ^~~~~~~~~~~
include/linux/dynamic_debug.h:250:59: note: expanded from macro '_dynamic_func_call'
250 | _dynamic_func_call_cls(_DPRINTK_CLASS_DFLT, fmt, func, ##__VA_ARGS__)
| ^~~~~~~~~~~
include/linux/dynamic_debug.h:248:65: note: expanded from macro '_dynamic_func_call_cls'
248 | __dynamic_func_call_cls(__UNIQUE_ID(ddebug), cls, fmt, func, ##__VA_ARGS__)
| ^~~~~~~~~~~
include/linux/dynamic_debug.h:224:15: note: expanded from macro '__dynamic_func_call_cls'
224 | func(&id, ##__VA_ARGS__); \
| ^~~~~~~~~~~
drivers/dma/at_hdmac.c:1509:13: warning: format specifies type 'int' but the argument has type 'size_t' (aka 'unsigned long') [-Wformat]
1506 | dev_vdbg(chan2dev(chan), "prep_dma_cyclic: %s buf@...d - %d (%d/%d)\n",
| ~~
| %zu
1507 | direction == DMA_MEM_TO_DEV ? "TO DEVICE" : "FROM DEVICE",
1508 | &buf_addr,
1509 | periods, buf_len, period_len);
| ^~~~~~~
include/linux/dev_printk.h:261:18: note: expanded from macro 'dev_vdbg'
261 | #define dev_vdbg dev_dbg
| ^
include/linux/dev_printk.h:165:39: note: expanded from macro 'dev_dbg'
165 | dynamic_dev_dbg(dev, dev_fmt(fmt), ##__VA_ARGS__)
| ~~~ ^~~~~~~~~~~
include/linux/dynamic_debug.h:274:19: note: expanded from macro 'dynamic_dev_dbg'
274 | dev, fmt, ##__VA_ARGS__)
| ~~~ ^~~~~~~~~~~
include/linux/dynamic_debug.h:250:59: note: expanded from macro '_dynamic_func_call'
250 | _dynamic_func_call_cls(_DPRINTK_CLASS_DFLT, fmt, func, ##__VA_ARGS__)
| ^~~~~~~~~~~
include/linux/dynamic_debug.h:248:65: note: expanded from macro '_dynamic_func_call_cls'
248 | __dynamic_func_call_cls(__UNIQUE_ID(ddebug), cls, fmt, func, ##__VA_ARGS__)
| ^~~~~~~~~~~
include/linux/dynamic_debug.h:224:15: note: expanded from macro '__dynamic_func_call_cls'
224 | func(&id, ##__VA_ARGS__); \
| ^~~~~~~~~~~
drivers/dma/at_hdmac.c:1509:22: warning: format specifies type 'int' but the argument has type 'size_t' (aka 'unsigned long') [-Wformat]
1506 | dev_vdbg(chan2dev(chan), "prep_dma_cyclic: %s buf@...d - %d (%d/%d)\n",
| ~~
| %zu
1507 | direction == DMA_MEM_TO_DEV ? "TO DEVICE" : "FROM DEVICE",
1508 | &buf_addr,
1509 | periods, buf_len, period_len);
| ^~~~~~~~~~
include/linux/dev_printk.h:261:18: note: expanded from macro 'dev_vdbg'
261 | #define dev_vdbg dev_dbg
| ^
include/linux/dev_printk.h:165:39: note: expanded from macro 'dev_dbg'
165 | dynamic_dev_dbg(dev, dev_fmt(fmt), ##__VA_ARGS__)
| ~~~ ^~~~~~~~~~~
include/linux/dynamic_debug.h:274:19: note: expanded from macro 'dynamic_dev_dbg'
274 | dev, fmt, ##__VA_ARGS__)
| ~~~ ^~~~~~~~~~~
include/linux/dynamic_debug.h:250:59: note: expanded from macro '_dynamic_func_call'
250 | _dynamic_func_call_cls(_DPRINTK_CLASS_DFLT, fmt, func, ##__VA_ARGS__)
| ^~~~~~~~~~~
include/linux/dynamic_debug.h:248:65: note: expanded from macro '_dynamic_func_call_cls'
248 | __dynamic_func_call_cls(__UNIQUE_ID(ddebug), cls, fmt, func, ##__VA_ARGS__)
| ^~~~~~~~~~~
include/linux/dynamic_debug.h:224:15: note: expanded from macro '__dynamic_func_call_cls'
224 | func(&id, ##__VA_ARGS__); \
| ^~~~~~~~~~~
5 warnings generated.
vim +891 drivers/dma/at_hdmac.c
dc78baa2b90b28 Nicolas Ferre 2009-07-03 858
dc78baa2b90b28 Nicolas Ferre 2009-07-03 859 /*-- DMA Engine API --------------------------------------------------*/
5abecfa5e96972 Maxime Ripard 2015-05-27 860 /**
5abecfa5e96972 Maxime Ripard 2015-05-27 861 * atc_prep_dma_interleaved - prepare memory to memory interleaved operation
5abecfa5e96972 Maxime Ripard 2015-05-27 862 * @chan: the channel to prepare operation on
5abecfa5e96972 Maxime Ripard 2015-05-27 863 * @xt: Interleaved transfer template
5abecfa5e96972 Maxime Ripard 2015-05-27 864 * @flags: tx descriptor status flags
5abecfa5e96972 Maxime Ripard 2015-05-27 865 */
5abecfa5e96972 Maxime Ripard 2015-05-27 866 static struct dma_async_tx_descriptor *
5abecfa5e96972 Maxime Ripard 2015-05-27 867 atc_prep_dma_interleaved(struct dma_chan *chan,
5abecfa5e96972 Maxime Ripard 2015-05-27 868 struct dma_interleaved_template *xt,
5abecfa5e96972 Maxime Ripard 2015-05-27 869 unsigned long flags)
5abecfa5e96972 Maxime Ripard 2015-05-27 870 {
ac803b56860f65 Tudor Ambarus 2022-10-25 871 struct at_dma *atdma = to_at_dma(chan->device);
5abecfa5e96972 Maxime Ripard 2015-05-27 872 struct at_dma_chan *atchan = to_at_dma_chan(chan);
62a277d43d47e7 Gustavo A. R. Silva 2017-11-20 873 struct data_chunk *first;
ac803b56860f65 Tudor Ambarus 2022-10-25 874 struct atdma_sg *atdma_sg;
ac803b56860f65 Tudor Ambarus 2022-10-25 875 struct at_desc *desc;
ac803b56860f65 Tudor Ambarus 2022-10-25 876 struct at_lli *lli;
5abecfa5e96972 Maxime Ripard 2015-05-27 877 size_t xfer_count;
5abecfa5e96972 Maxime Ripard 2015-05-27 878 unsigned int dwidth;
5abecfa5e96972 Maxime Ripard 2015-05-27 879 u32 ctrla;
5abecfa5e96972 Maxime Ripard 2015-05-27 880 u32 ctrlb;
5abecfa5e96972 Maxime Ripard 2015-05-27 881 size_t len = 0;
5abecfa5e96972 Maxime Ripard 2015-05-27 882 int i;
5abecfa5e96972 Maxime Ripard 2015-05-27 883
4483320e241c5f Maninder Singh 2015-06-26 884 if (unlikely(!xt || xt->numf != 1 || !xt->frame_size))
4483320e241c5f Maninder Singh 2015-06-26 885 return NULL;
4483320e241c5f Maninder Singh 2015-06-26 886
62a277d43d47e7 Gustavo A. R. Silva 2017-11-20 887 first = xt->sgl;
62a277d43d47e7 Gustavo A. R. Silva 2017-11-20 888
5abecfa5e96972 Maxime Ripard 2015-05-27 889 dev_info(chan2dev(chan),
2c5d7407e01272 Arnd Bergmann 2015-11-12 890 "%s: src=%pad, dest=%pad, numf=%d, frame_size=%d, flags=0x%lx\n",
2c5d7407e01272 Arnd Bergmann 2015-11-12 @891 __func__, &xt->src_start, &xt->dst_start, xt->numf,
5abecfa5e96972 Maxime Ripard 2015-05-27 892 xt->frame_size, flags);
5abecfa5e96972 Maxime Ripard 2015-05-27 893
5abecfa5e96972 Maxime Ripard 2015-05-27 894 /*
5abecfa5e96972 Maxime Ripard 2015-05-27 895 * The controller can only "skip" X bytes every Y bytes, so we
5abecfa5e96972 Maxime Ripard 2015-05-27 896 * need to make sure we are given a template that fit that
5abecfa5e96972 Maxime Ripard 2015-05-27 897 * description, ie a template with chunks that always have the
5abecfa5e96972 Maxime Ripard 2015-05-27 898 * same size, with the same ICGs.
5abecfa5e96972 Maxime Ripard 2015-05-27 899 */
5abecfa5e96972 Maxime Ripard 2015-05-27 900 for (i = 0; i < xt->frame_size; i++) {
5abecfa5e96972 Maxime Ripard 2015-05-27 901 struct data_chunk *chunk = xt->sgl + i;
5abecfa5e96972 Maxime Ripard 2015-05-27 902
5abecfa5e96972 Maxime Ripard 2015-05-27 903 if ((chunk->size != xt->sgl->size) ||
5abecfa5e96972 Maxime Ripard 2015-05-27 904 (dmaengine_get_dst_icg(xt, chunk) != dmaengine_get_dst_icg(xt, first)) ||
5abecfa5e96972 Maxime Ripard 2015-05-27 905 (dmaengine_get_src_icg(xt, chunk) != dmaengine_get_src_icg(xt, first))) {
5abecfa5e96972 Maxime Ripard 2015-05-27 906 dev_err(chan2dev(chan),
5abecfa5e96972 Maxime Ripard 2015-05-27 907 "%s: the controller can transfer only identical chunks\n",
5abecfa5e96972 Maxime Ripard 2015-05-27 908 __func__);
5abecfa5e96972 Maxime Ripard 2015-05-27 909 return NULL;
5abecfa5e96972 Maxime Ripard 2015-05-27 910 }
5abecfa5e96972 Maxime Ripard 2015-05-27 911
5abecfa5e96972 Maxime Ripard 2015-05-27 912 len += chunk->size;
5abecfa5e96972 Maxime Ripard 2015-05-27 913 }
5abecfa5e96972 Maxime Ripard 2015-05-27 914
ac803b56860f65 Tudor Ambarus 2022-10-25 915 dwidth = atc_get_xfer_width(xt->src_start, xt->dst_start, len);
5abecfa5e96972 Maxime Ripard 2015-05-27 916
5abecfa5e96972 Maxime Ripard 2015-05-27 917 xfer_count = len >> dwidth;
5abecfa5e96972 Maxime Ripard 2015-05-27 918 if (xfer_count > ATC_BTSIZE_MAX) {
5abecfa5e96972 Maxime Ripard 2015-05-27 919 dev_err(chan2dev(chan), "%s: buffer is too big\n", __func__);
5abecfa5e96972 Maxime Ripard 2015-05-27 920 return NULL;
5abecfa5e96972 Maxime Ripard 2015-05-27 921 }
5abecfa5e96972 Maxime Ripard 2015-05-27 922
d8840a7edcf0aa Tudor Ambarus 2022-10-25 923 ctrla = FIELD_PREP(ATC_SRC_WIDTH, dwidth) |
d8840a7edcf0aa Tudor Ambarus 2022-10-25 924 FIELD_PREP(ATC_DST_WIDTH, dwidth);
5abecfa5e96972 Maxime Ripard 2015-05-27 925
d8840a7edcf0aa Tudor Ambarus 2022-10-25 926 ctrlb = ATC_DEFAULT_CTRLB | ATC_IEN |
d8840a7edcf0aa Tudor Ambarus 2022-10-25 927 FIELD_PREP(ATC_SRC_ADDR_MODE, ATC_SRC_ADDR_MODE_INCR) |
d8840a7edcf0aa Tudor Ambarus 2022-10-25 928 FIELD_PREP(ATC_DST_ADDR_MODE, ATC_DST_ADDR_MODE_INCR) |
d8840a7edcf0aa Tudor Ambarus 2022-10-25 929 ATC_SRC_PIP | ATC_DST_PIP |
d8840a7edcf0aa Tudor Ambarus 2022-10-25 930 FIELD_PREP(ATC_FC, ATC_FC_MEM2MEM);
5abecfa5e96972 Maxime Ripard 2015-05-27 931
ac803b56860f65 Tudor Ambarus 2022-10-25 932 desc = kzalloc(struct_size(desc, sg, 1), GFP_ATOMIC);
ac803b56860f65 Tudor Ambarus 2022-10-25 933 if (!desc)
ac803b56860f65 Tudor Ambarus 2022-10-25 934 return NULL;
ac803b56860f65 Tudor Ambarus 2022-10-25 935 desc->sglen = 1;
ac803b56860f65 Tudor Ambarus 2022-10-25 936
ac803b56860f65 Tudor Ambarus 2022-10-25 937 atdma_sg = desc->sg;
ac803b56860f65 Tudor Ambarus 2022-10-25 938 atdma_sg->lli = dma_pool_alloc(atdma->lli_pool, GFP_NOWAIT,
ac803b56860f65 Tudor Ambarus 2022-10-25 939 &atdma_sg->lli_phys);
ac803b56860f65 Tudor Ambarus 2022-10-25 940 if (!atdma_sg->lli) {
ac803b56860f65 Tudor Ambarus 2022-10-25 941 kfree(desc);
5abecfa5e96972 Maxime Ripard 2015-05-27 942 return NULL;
5abecfa5e96972 Maxime Ripard 2015-05-27 943 }
ac803b56860f65 Tudor Ambarus 2022-10-25 944 lli = atdma_sg->lli;
5abecfa5e96972 Maxime Ripard 2015-05-27 945
ac803b56860f65 Tudor Ambarus 2022-10-25 946 lli->saddr = xt->src_start;
ac803b56860f65 Tudor Ambarus 2022-10-25 947 lli->daddr = xt->dst_start;
ac803b56860f65 Tudor Ambarus 2022-10-25 948 lli->ctrla = ctrla | xfer_count;
ac803b56860f65 Tudor Ambarus 2022-10-25 949 lli->ctrlb = ctrlb;
5abecfa5e96972 Maxime Ripard 2015-05-27 950
5abecfa5e96972 Maxime Ripard 2015-05-27 951 desc->boundary = first->size >> dwidth;
5abecfa5e96972 Maxime Ripard 2015-05-27 952 desc->dst_hole = (dmaengine_get_dst_icg(xt, first) >> dwidth) + 1;
5abecfa5e96972 Maxime Ripard 2015-05-27 953 desc->src_hole = (dmaengine_get_src_icg(xt, first) >> dwidth) + 1;
5abecfa5e96972 Maxime Ripard 2015-05-27 954
ac803b56860f65 Tudor Ambarus 2022-10-25 955 atdma_sg->len = len;
ac803b56860f65 Tudor Ambarus 2022-10-25 956 desc->total_len = len;
5abecfa5e96972 Maxime Ripard 2015-05-27 957
ac803b56860f65 Tudor Ambarus 2022-10-25 958 set_lli_eol(desc, 0);
ac803b56860f65 Tudor Ambarus 2022-10-25 959 return vchan_tx_prep(&atchan->vc, &desc->vd, flags);
5abecfa5e96972 Maxime Ripard 2015-05-27 960 }
5abecfa5e96972 Maxime Ripard 2015-05-27 961
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
Powered by blists - more mailing lists