linux-kernel - Re: [PATCH] android: binder: modify incorrect comments

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZtMlwFZdMjgfgdOv@google.com>
Date: Sat, 31 Aug 2024 14:16:32 +0000
From: Carlos Llamas <cmllamas@...gle.com>
To: bajing <bajing@...s.chinamobile.com>
Cc: gregkh@...uxfoundation.org, arve@...roid.com, tkjos@...roid.com,
	maco@...roid.com, joel@...lfernandes.org, brauner@...nel.org,
	surenb@...gle.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] android: binder: modify incorrect comments

On Fri, Aug 30, 2024 at 03:37:43PM +0800, bajing wrote:
> The comment for binder_proc_unlock was incorrect, so it should be modified.

Can you specify why the comment is incorrect?

> 
> Signed-off-by: bajing <bajing@...s.chinamobile.com>
> ---
>  drivers/android/binder.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/android/binder.c b/drivers/android/binder.c
> index fc55b5d0e4f3..578861d57045 100644
> --- a/drivers/android/binder.c
> +++ b/drivers/android/binder.c
> @@ -277,7 +277,7 @@ _binder_proc_lock(struct binder_proc *proc, int line)
>  }
>  
>  /**
> - * binder_proc_unlock() - Release spinlock for given binder_proc
> + * binder_proc_unlock() - Release outer lock for given binder_proc
>   * @proc:                struct binder_proc to acquire
>   *
>   * Release lock acquired via binder_proc_lock()
> -- 
> 2.33.0
> 

I'm ok with your change. It is specific about which spinlock it releases
(even though this is obvious from the code). It also pairs better with
the acquire comment block in binder_proc_lock().

However, you need to modify your commit message as the current comment
is technically _not_ incorrect. Can you please send a v2?

Thanks,
--
Carlos Llamas