linux-kernel - Re: [PATCH] staging: rtl8192e: Rename variable eRFPath

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <225c7675-3526-40a3-ae9d-877ff8e4f250@stanley.mountain>
Date: Sat, 31 Aug 2024 18:14:50 +0300
From: Dan Carpenter <dan.carpenter@...aro.org>
To: Riyan Dhiman <riyandhiman14@...il.com>
Cc: gregkh@...uxfoundation.org, linux-kernel@...r.kernel.org,
	linux-staging@...ts.linux.dev
Subject: Re: [PATCH] staging: rtl8192e: Rename variable eRFPath

On Sat, Aug 31, 2024 at 08:29:32PM +0530, Riyan Dhiman wrote:
> Rename variable eRFPath to erf_path to fix checkpatch
> warning.
> 
> Issue reported in checkpatch:
> -CHECK: Avoid CamelCase: <eRFPath>
> 
> Signed-off-by: Riyan Dhiman <riyandhiman14@...il.com>
> ---
>  .../staging/rtl8192e/rtl8192e/r8190P_rtl8256.c   | 16 ++++++++--------
>  1 file changed, 8 insertions(+), 8 deletions(-)
> 
> diff --git a/drivers/staging/rtl8192e/rtl8192e/r8190P_rtl8256.c b/drivers/staging/rtl8192e/rtl8192e/r8190P_rtl8256.c
> index 7061f1cf4d3a..256c19739ad1 100644
> --- a/drivers/staging/rtl8192e/rtl8192e/r8190P_rtl8256.c
> +++ b/drivers/staging/rtl8192e/rtl8192e/r8190P_rtl8256.c
> @@ -12,7 +12,7 @@
>  void rtl92e_set_bandwidth(struct net_device *dev,
>  			  enum ht_channel_width bandwidth)
>  {
> -	u8	eRFPath;
> +	u8	erf_path;

e stands for enum.  We don't like this kind of name.  Just call it rf_path.

regards,
dan carpenter