linux-kernel - Re: [PATCH] mm/vmscan: wake up flushers conditionally to avoid cgroup OOM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20240830173813.c53769f62bf72116266f42ca@linux-foundation.org>
Date: Fri, 30 Aug 2024 17:38:13 -0700
From: Andrew Morton <akpm@...ux-foundation.org>
To: Jingxiang Zeng <linuszeng@...cent.com>
Cc: Jingxiang Zeng <jingxiangzeng.cas@...il.com>, linux-mm@...ck.org, Yu
 Zhao <yuzhao@...gle.com>, Wei Xu <weixugc@...gle.com>, "T . J . Mercier"
 <tjmercier@...gle.com>, Kairui Song <kasong@...cent.com>,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mm/vmscan: wake up flushers conditionally to avoid
 cgroup OOM

On Thu, 29 Aug 2024 18:25:43 +0800 Jingxiang Zeng <jingxiangzeng.cas@...il.com> wrote:

> From: Zeng Jingxiang <linuszeng@...cent.com>
> 
> Commit 14aa8b2d5c2e ("mm/mglru: don't sync disk for each aging cycle")
> removed the opportunity to wake up flushers during the MGLRU page
> reclamation process can lead to an increased likelihood of triggering
> OOM when encountering many dirty pages during reclamation on MGLRU.
> 
> This leads to premature OOM if there are too many dirty pages in cgroup:
> Killed
> 
> ...
>
> The flusher wake up was removed to decrease SSD wearing, but if we are 
> seeing all dirty folios at the tail of an LRU, not waking up the flusher 
> could lead to thrashing easily. So wake it up when a mem cgroups is 
> about to OOM due to dirty caches.

Thanks, I'll queue this for testing and review.  Could people please
consider whether we should backport this into -stable kernels.

> MGLRU still suffers OOM issue on latest mm tree, so the test is done
> with another fix merged [1].
> 
> Link: https://lore.kernel.org/linux-mm/CAOUHufYi9h0kz5uW3LHHS3ZrVwEq-kKp8S6N-MZUmErNAXoXmw@mail.gmail.com/ [1]

This one is already queued for -stable.