linux-kernel - Re: [PATCH v13 04/10] mm: split a folio in minimum folio order chunks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <C03CDEA0-1603-4D63-92E4-5B79820D1B45@nvidia.com>
Date: Sat, 31 Aug 2024 18:38:57 -0400
From: Zi Yan <ziy@...dia.com>
To: Luis Chamberlain <mcgrof@...nel.org>
Cc: Pankaj Raghav <kernel@...kajraghav.com>,
 Matthew Wilcox <willy@...radead.org>, Sven Schnelle <svens@...ux.ibm.com>,
 brauner@...nel.org, akpm@...ux-foundation.org, chandan.babu@...cle.com,
 linux-fsdevel@...r.kernel.org, djwong@...nel.org, hare@...e.de,
 gost.dev@...sung.com, linux-xfs@...r.kernel.org, hch@....de,
 david@...morbit.com, yang@...amperecomputing.com,
 linux-kernel@...r.kernel.org, linux-mm@...ck.org, john.g.garry@...cle.com,
 cl@...amperecomputing.com, p.raghav@...sung.com, ryan.roberts@....com,
 David Howells <dhowells@...hat.com>, linux-s390@...r.kernel.org
Subject: Re: [PATCH v13 04/10] mm: split a folio in minimum folio order chunks

On 30 Aug 2024, at 13:12, Luis Chamberlain wrote:

> On Fri, Aug 30, 2024 at 04:59:57PM +0200, Pankaj Raghav wrote:
>> It feels a bit weird to pass both folio and the page in `split_page_folio_to_list()`.
>
> Agreed..
>
>> How about we extract the code that returns the min order so that we don't repeat.
>> Something like this:
>
> Of all solutions I like this the most, Zi, do you have any preference?

No preference, as long as Pankaj fixed the "if (ret)" issue I mentioned in the
other email.

--
Best Regards,
Yan, Zi

Download attachment "signature.asc" of type "application/pgp-signature" (855 bytes)