linux-kernel - Re: [PATCH] firmware: qcom: uefisecapp: Fix deadlock in qcuefi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <172507431835.12792.13483541380565226946.b4-ty@kernel.org>
Date: Fri, 30 Aug 2024 22:18:37 -0500
From: Bjorn Andersson <andersson@...nel.org>
To: Maximilian Luz <luzmaximilian@...il.com>,
	Dan Carpenter <dan.carpenter@...aro.org>
Cc: Konrad Dybcio <konradybcio@...nel.org>,
	Johan Hovold <johan+linaro@...nel.org>,
	Ard Biesheuvel <ardb@...nel.org>,
	linux-arm-msm@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] firmware: qcom: uefisecapp: Fix deadlock in qcuefi_acquire()


On Thu, 29 Aug 2024 22:23:04 +0300, Dan Carpenter wrote:
> If the __qcuefi pointer is not set, then in the original code, we would
> hold onto the lock.  That means that if we tried to set it later, then
> it would cause a deadlock.  Drop the lock on the error path.  That's
> what all the callers are expecting.
> 
> 

Applied, thanks!

[1/1] firmware: qcom: uefisecapp: Fix deadlock in qcuefi_acquire()
      commit: db213b0cfe3268d8b1d382b3bcc999c687a2567f

Best regards,
-- 
Bjorn Andersson <andersson@...nel.org>