linux-kernel - Re: [PATCH v2 02/12] kconfig: refactor choice value calculation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20240901093212.GC3708622@ragnatech.se>
Date: Sun, 1 Sep 2024 11:32:12 +0200
From: Niklas Söderlund <niklas.soderlund@...natech.se>
To: Masahiro Yamada <masahiroy@...nel.org>
Cc: linux-kbuild@...r.kernel.org, linux-kernel@...r.kernel.org,
	Marek Vasut <marex@...x.de>
Subject: Re: [PATCH v2 02/12] kconfig: refactor choice value calculation

On 2024-09-01 18:10:56 +0900, Masahiro Yamada wrote:
> On Sun, Sep 1, 2024 at 2:31 AM Niklas Söderlund
> <niklas.soderlund@...natech.se> wrote:
> >
> > Hello Yamada-san,
> >
> > Thanks for your work.
> >
> > I bisected a kconfig issue to this change, but I'm not sure how to
> > resolve it and would appreciate your help.
> >
> > Before this changes if I run menuconfig,
> >
> >     $ ARCH=arm64 make menuconfig
> >
> > The menu option for by SOC_RENESAS is visible at
> >
> >     Device Drivers ->
> >         SOC (System On Chip) specific Drivers ->
> >             Renesas SoC driver support
> >
> > However after this patch it is not.
> >
> > Furthermore searching (/) for any config option protected by SOC_RENESAS
> > in drivers/soc/renesas/Kconfig (e.g. ARCH_R8A77965) results in a search
> > hit, but if I try to jump to it by pressing 1 all I get is a blank
> > screen.
> >
> > I'm not sure if a fix to the for mention Kconfig file is needed or if
> > something else is wrong. This is still true for today's linux-next [1].
> >
> > 1. 985bf40edf43 ("Add linux-next specific files for 20240830")
> 
> 
> 
> 
> 
> 
> The prompt of SOC_RENESAS depends on
> COMPILE_TEST && !ARCH_RENESAS.
> Hence, it is hidden by default.
> 
> Pressing (1) navigated to the nearest parent menu.
> 
> Setting COMPILE_TEST=y and ARCH_RENESAS=n made it visible.

It might be that the Kconfig file needs an update, but the behavior 
changed with this commit.

Before this commit the entry was visible and symbols hidden under the 
SOC_RENESAS where selectable and I could for example select/deselect 
ARCH_R8A77965 in menuconfig. After this change I can't navigate to 
ARCH_R8A77965 at all.

But you are correct that both before and after the commit the 
SOC_RENESAS symbol is set to only be visible if 'COMPILE_TEST && 
!ARCH_RENESAS' so this might have been an issue that was fixed and that 
the Kconfig file needs to be updated.

Thanks for your help!

> 
> All look quite normal to me.
> 
> 
> 
>  Symbol: SOC_RENESAS [=y]
>  Type  : bool
>  Defined at drivers/soc/renesas/Kconfig:2
>    Prompt: Renesas SoC driver support
>    Visible if: COMPILE_TEST [=n] && !ARCH_RENESAS [=y]
>    Location:
>      -> Device Drivers
>  (1)   -> SOC (System On Chip) specific Drivers
>          -> Renesas SoC driver support (SOC_RENESAS [=y])
>  Selects: GPIOLIB [=y] && PINCTRL [=y] && SOC_BUS [=y]
> 
> 
> 
> 
> 
> 
> -- 
> Best Regards
> Masahiro Yamada

-- 
Kind Regards,
Niklas Söderlund