linux-kernel - Re: [PATCH v2 1/7] staging: vchiq: Factor out bulk transfer for VCHIQ_BULK_MODE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <202409011052.hHoEnTUy-lkp@intel.com>
Date: Sun, 1 Sep 2024 10:28:14 +0800
From: kernel test robot <lkp@...el.com>
To: Umang Jain <umang.jain@...asonboard.com>,
	Florian Fainelli <florian.fainelli@...adcom.com>,
	Broadcom internal kernel review list <bcm-kernel-feedback-list@...adcom.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc: oe-kbuild-all@...ts.linux.dev, linux-rpi-kernel@...ts.infradead.org,
	linux-arm-kernel@...ts.infradead.org, linux-staging@...ts.linux.dev,
	linux-kernel@...r.kernel.org,
	Kieran Bingham <kieran.bingham@...asonboard.com>,
	Arnd Bergmann <arnd@...db.de>, Stefan Wahren <wahrenst@....net>,
	Dave Stevenson <dave.stevenson@...pberrypi.com>,
	Phil Elwell <phil@...pberrypi.com>,
	Laurent Pinchart <laurent.pinchart@...asonboard.com>,
	Umang Jain <umang.jain@...asonboard.com>
Subject: Re: [PATCH v2 1/7] staging: vchiq: Factor out bulk transfer for
 VCHIQ_BULK_MODE_WAITING

Hi Umang,

kernel test robot noticed the following build warnings:

[auto build test WARNING on staging/staging-testing]

url:    https://github.com/intel-lab-lkp/linux/commits/Umang-Jain/staging-vchiq-Factor-out-bulk-transfer-for-VCHIQ_BULK_MODE_WAITING/20240901-002839
base:   staging/staging-testing
patch link:    https://lore.kernel.org/r/20240831162435.191084-2-umang.jain%40ideasonboard.com
patch subject: [PATCH v2 1/7] staging: vchiq: Factor out bulk transfer for VCHIQ_BULK_MODE_WAITING
config: i386-buildonly-randconfig-001-20240901 (https://download.01.org/0day-ci/archive/20240901/202409011052.hHoEnTUy-lkp@intel.com/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240901/202409011052.hHoEnTUy-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202409011052.hHoEnTUy-lkp@intel.com/

All warnings (new ones prefixed by >>):

   drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c: In function 'vchiq_bulk_xfer_waiting_interruptible':
>> drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c:3152:28: warning: variable 'bulk' set but not used [-Wunused-but-set-variable]
    3152 |         struct vchiq_bulk *bulk;
         |                            ^~~~


vim +/bulk +3152 drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c

  3140	
  3141	/*
  3142	 * This function is called by VCHIQ ioctl interface and is interruptible.
  3143	 * It may receive -EAGAIN to indicate that a signal has been received
  3144	 * and the call should be retried after being returned to user context.
  3145	 */
  3146	int
  3147	vchiq_bulk_xfer_waiting_interruptible(struct vchiq_instance *instance,
  3148					      unsigned int handle, struct bulk_waiter *userdata)
  3149	{
  3150		struct vchiq_service *service = find_service_by_handle(instance, handle);
  3151		struct bulk_waiter *bulk_waiter;
> 3152		struct vchiq_bulk *bulk;
  3153		int status = -EINVAL;
  3154	
  3155		if (!service)
  3156			goto error_exit;
  3157	
  3158		if (!userdata)
  3159			goto error_exit;
  3160	
  3161		if (service->srvstate != VCHIQ_SRVSTATE_OPEN)
  3162			goto error_exit;
  3163	
  3164		if (vchiq_check_service(service))
  3165			goto error_exit;
  3166	
  3167		bulk_waiter = userdata;
  3168		bulk = bulk_waiter->bulk;
  3169	
  3170		vchiq_service_put(service);
  3171	
  3172		status = 0;
  3173	
  3174		if (wait_for_completion_interruptible(&bulk_waiter->event))
  3175			return -EAGAIN;
  3176		else if (bulk_waiter->actual == VCHIQ_BULK_ACTUAL_ABORTED)
  3177			return -EINVAL;
  3178	
  3179		return status;
  3180	
  3181	error_exit:
  3182		if (service)
  3183			vchiq_service_put(service);
  3184		return status;
  3185	}
  3186	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki