linux-kernel - Re: [PATCH v6 1/3] arch: vDSO: Add a __vdso_getrandom prototype for all architectures

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZtRq22l9ZLIKP5cf@zx2c4.com>
Date: Sun, 1 Sep 2024 15:23:39 +0200
From: "Jason A. Donenfeld" <Jason@...c4.com>
To: Huacai Chen <chenhuacai@...nel.org>
Cc: Xi Ruoyao <xry111@...111.site>, WANG Xuerui <kernel@...0n.name>,
	linux-crypto@...r.kernel.org, loongarch@...ts.linux.dev,
	linux-kernel@...r.kernel.org, Jinyang He <hejinyang@...ngson.cn>,
	Tiezhu Yang <yangtiezhu@...ngson.cn>,
	Christophe Leroy <christophe.leroy@...roup.eu>,
	Arnd Bergmann <arnd@...db.de>
Subject: Re: [PATCH v6 1/3] arch: vDSO: Add a __vdso_getrandom prototype for
 all architectures

On Sun, Sep 01, 2024 at 04:44:40PM +0800, Huacai Chen wrote:
> Hi, Ruoyao,
> 
> On Sun, Sep 1, 2024 at 2:13 PM Xi Ruoyao <xry111@...111.site> wrote:
> >
> > Without a prototype, we'll have to add a prototype for each architecture
> > implementing vDSO getrandom.  As most architectures will likely have the
> > vDSO getrandom implemented in a near future, and we'd like to keep the
> > declarations compatible everywhere (to ease the Glibc work), we should
> > really just have one copy of the prototype.
> >
> > Suggested-by: Huacai Chen <chenhuacai@...nel.org>
> > Signed-off-by: Xi Ruoyao <xry111@...111.site>
> > ---
> >  arch/x86/entry/vdso/vgetrandom.c | 2 --
> >  include/vdso/getrandom.h         | 5 +++++
> >  2 files changed, 5 insertions(+), 2 deletions(-)
> >
> > diff --git a/arch/x86/entry/vdso/vgetrandom.c b/arch/x86/entry/vdso/vgetrandom.c
> > index 52d3c7faae2e..430862b8977c 100644
> > --- a/arch/x86/entry/vdso/vgetrandom.c
> > +++ b/arch/x86/entry/vdso/vgetrandom.c
> > @@ -6,8 +6,6 @@
> >
> >  #include "../../../../lib/vdso/getrandom.c"
> >
> > -ssize_t __vdso_getrandom(void *buffer, size_t len, unsigned int flags, void *opaque_state, size_t opaque_len);
> > -
> >  ssize_t __vdso_getrandom(void *buffer, size_t len, unsigned int flags, void *opaque_state, size_t opaque_len)
> >  {
> >         return __cvdso_getrandom(buffer, len, flags, opaque_state, opaque_len);
> > diff --git a/include/vdso/getrandom.h b/include/vdso/getrandom.h
> > index 4cf02e678f5e..08b47b002bf7 100644
> > --- a/include/vdso/getrandom.h
> > +++ b/include/vdso/getrandom.h
> > @@ -56,4 +56,9 @@ struct vgetrandom_state {
> >   */
> >  extern void __arch_chacha20_blocks_nostack(u8 *dst_bytes, const u32 *key, u32 *counter, size_t nblocks);
> >
> > +/**
> Though in this file there are already comments beginning with /**, but
> it seems the kernel's code style suggests beginning with /*.

/** is for docbook comments.