linux-kernel - Re: [PATCH] hwmon: ltc2991: fix register bits defines

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <02cf392d-57cb-48fe-930d-597f415520a4@roeck-us.net>
Date: Sun, 1 Sep 2024 06:40:17 -0700
From: Guenter Roeck <linux@...ck-us.net>
To: Pawel Dembicki <paweldembicki@...il.com>
Cc: linux-hwmon@...r.kernel.org,
	Antoniu Miclaus <antoniu.miclaus@...log.com>,
	Jean Delvare <jdelvare@...e.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] hwmon: ltc2991: fix register bits defines

On Fri, Aug 30, 2024 at 01:13:50PM +0200, Pawel Dembicki wrote:
> In the LTC2991, V5 and V6 channels use the low nibble of the
> "V5, V6, V7, and V8 Control Register" for configuration, but currently,
> the high nibble is defined.
> 
> This patch changes the defines to use the low nibble.
> 
> Fixes: 2b9ea4262ae9 ("hwmon: Add driver for ltc2991")
> Signed-off-by: Pawel Dembicki <paweldembicki@...il.com>

Applied.

Thanks,
Guenter

> ---
>  drivers/hwmon/ltc2991.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/hwmon/ltc2991.c b/drivers/hwmon/ltc2991.c
> index 573cd8f5721b..7ca139e4b6af 100644
> --- a/drivers/hwmon/ltc2991.c
> +++ b/drivers/hwmon/ltc2991.c
> @@ -42,9 +42,9 @@
>  #define LTC2991_V7_V8_FILT_EN		BIT(7)
>  #define LTC2991_V7_V8_TEMP_EN		BIT(5)
>  #define LTC2991_V7_V8_DIFF_EN		BIT(4)
> -#define LTC2991_V5_V6_FILT_EN		BIT(7)
> -#define LTC2991_V5_V6_TEMP_EN		BIT(5)
> -#define LTC2991_V5_V6_DIFF_EN		BIT(4)
> +#define LTC2991_V5_V6_FILT_EN		BIT(3)
> +#define LTC2991_V5_V6_TEMP_EN		BIT(1)
> +#define LTC2991_V5_V6_DIFF_EN		BIT(0)
>  
>  #define LTC2991_REPEAT_ACQ_EN		BIT(4)
>  #define LTC2991_T_INT_FILT_EN		BIT(3)