linux-kernel - RE: [PATCH -next] genirq/timings: Use min

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b7cc4af3df4c41b3975ac990532e4ba0@AcuMS.aculab.com>
Date: Sun, 1 Sep 2024 20:53:09 +0000
From: David Laight <David.Laight@...LAB.COM>
To: 'Jinjie Ruan' <ruanjinjie@...wei.com>, "tglx@...utronix.de"
	<tglx@...utronix.de>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>
Subject: RE: [PATCH -next] genirq/timings: Use min_t() to simplify the code

From: Jinjie Ruan
> Sent: 31 August 2024 10:37
> 
> The irq count can not exceed circular buffer IRQ_TIMINGS_SIZE, use
> min_t() to simplify it.
> 
> Signed-off-by: Jinjie Ruan <ruanjinjie@...wei.com>
> ---
>  kernel/irq/timings.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/kernel/irq/timings.c b/kernel/irq/timings.c
> index c43e2ac2f8de..69f103b4c7a6 100644
> --- a/kernel/irq/timings.c
> +++ b/kernel/irq/timings.c
> @@ -406,8 +406,7 @@ static u64 __irq_timings_next_event(struct irqt_stat *irqs, int irq, u64 now)
>  	/*
>  	 * 'count' will depends if the circular buffer wrapped or not
>  	 */
> -	count = irqs->count < IRQ_TIMINGS_SIZE ?
> -		irqs->count : IRQ_TIMINGS_SIZE;
> +	count = min_t(int, irqs->count, IRQ_TIMINGS_SIZE);

Why min_t() ?

	David

> 
>  	start = irqs->count < IRQ_TIMINGS_SIZE ?
>  		0 : (irqs->count & IRQ_TIMINGS_MASK);
> --
> 2.34.1
> 

-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)