linux-kernel - Re: [PATCH] 9p: cap xattr max size to XATTR_SIZE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240901-075b24ce58df695232e3d345-pchelkin@ispras.ru>
Date: Sun, 1 Sep 2024 10:16:55 +0300
From: Fedor Pchelkin <pchelkin@...ras.ru>
To: Christian Schoenebeck <linux_oss@...debyte.com>,
	Dominique Martinet <asmadeus@...ewreck.org>
Cc: Eric Van Hensbergen <ericvh@...nel.org>,
	Latchesar Ionkov <lucho@...kov.net>, v9fs@...ts.linux.dev,
	linux-kernel@...r.kernel.org,
	Christian Brauner <brauner@...nel.org>,
	xingwei lee <xrivendell7@...il.com>,
	sam sun <samsun1006219@...il.com>, lvc-project@...uxtesting.org,
	Alexey Khoroshilov <khoroshilov@...ras.ru>
Subject: Re: [PATCH] 9p: cap xattr max size to XATTR_SIZE_MAX

Hi Dominique and Christian,

the issue is still present in upstream kernel [1].

Considering the remark from Christian that limiting the allocation to
XATTR_SIZE_MAX seems too Linux-specific, maybe just fail silently with
__GFP_NOWARN flag passed to the allocator and return ENOMEM? I submitted
the patch [2] sometime ago which looks still applicable to the mainline
kernel. It was superseded with current discussion.

[1]: https://syzkaller.appspot.com/bug?extid=a83dc51a78f0f4cf20da
[2]: https://lore.kernel.org/lkml/20240202121319.21743-1-pchelkin@ispras.ru/