linux-kernel - Re: [PATCH] dax: Remove an unused field in struct dax

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20240902140911.puhunqx4qg7rqy6b@quack3>
Date: Mon, 2 Sep 2024 16:09:11 +0200
From: Jan Kara <jack@...e.cz>
To: Christophe JAILLET <christophe.jaillet@...adoo.fr>
Cc: Dan Williams <dan.j.williams@...el.com>,
	Matthew Wilcox <willy@...radead.org>, Jan Kara <jack@...e.cz>,
	linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org,
	linux-fsdevel@...r.kernel.org, nvdimm@...ts.linux.dev
Subject: Re: [PATCH] dax: Remove an unused field in struct dax_operations

On Sun 01-09-24 17:17:09, Christophe JAILLET wrote:
> .dax_supported() was apparently removed by commit 7b0800d00dae ("dax:
> remove dax_capable") on 2021-11.
> 
> Remove the now unused function pointer from the struct dax_operations.
> 
> Signed-off-by: Christophe JAILLET <christophe.jaillet@...adoo.fr>

Looks good. Feel free to add:

Reviewed-by: Jan Kara <jack@...e.cz>

								Honza

> ---
> Slightly compile tested only, but "git grep dax_supported" now returns
> nothing.
> ---
>  include/linux/dax.h | 6 ------
>  1 file changed, 6 deletions(-)
> 
> diff --git a/include/linux/dax.h b/include/linux/dax.h
> index 9d3e3327af4c..df41a0017b31 100644
> --- a/include/linux/dax.h
> +++ b/include/linux/dax.h
> @@ -27,12 +27,6 @@ struct dax_operations {
>  	 */
>  	long (*direct_access)(struct dax_device *, pgoff_t, long,
>  			enum dax_access_mode, void **, pfn_t *);
> -	/*
> -	 * Validate whether this device is usable as an fsdax backing
> -	 * device.
> -	 */
> -	bool (*dax_supported)(struct dax_device *, struct block_device *, int,
> -			sector_t, sector_t);
>  	/* zero_page_range: required operation. Zero page range   */
>  	int (*zero_page_range)(struct dax_device *, pgoff_t, size_t);
>  	/*
> -- 
> 2.46.0
> 
-- 
Jan Kara <jack@...e.com>
SUSE Labs, CR