linux-kernel - Re: [PATCH v2 2/5] mtd: spinand: add OTP support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240902161844.2bf982ef@xps-13>
Date: Mon, 2 Sep 2024 16:18:44 +0200
From: Miquel Raynal <miquel.raynal@...tlin.com>
To: Martin Kurbanov <mmkurbanov@...utedevices.com>
Cc: <linux-kernel@...r.kernel.org>, <linux-mtd@...ts.infradead.org>,
 <kernel@...utedevices.com>, Richard Weinberger <richard@....at>, "Vignesh
 Raghavendra" <vigneshr@...com>, Mika Westerberg
 <mika.westerberg@...ux.intel.com>, Michael Walle <michael@...le.cc>, "Mark
 Brown" <broonie@...nel.org>, Chia-Lin Kao <acelan.kao@...onical.com>, "Md
 Sadre Alam" <quic_mdalam@...cinc.com>, Ezra Buehler
 <ezra.buehler@...qvarnagroup.com>, Sridharan S N <quic_sridsn@...cinc.com>,
 Frieder Schrempf <frieder.schrempf@...tron.de>, Alexey Romanov
 <avromanov@...utedevices.com>
Subject: Re: [PATCH v2 2/5] mtd: spinand: add OTP support

Hi Martin,

mmkurbanov@...utedevices.com wrote on Tue, 27 Aug 2024 20:57:04 +0300:

> Hello, Miquel. Thank you for the review.
> Regarding your question ( https://lore.kernel.org/all/20240717103623.6d6b63be@xps-13/ ):
> 
> >> +int spinand_otp_read(struct spinand_device *spinand, loff_t from, size_t len,
> >> +		     u8 *buf, size_t *retlen);
> >> +
> >> +int spinand_otp_write(struct spinand_device *spinand, loff_t from, size_t len,
> >> +		      const u8 *buf, size_t *retlen);
> >> +  
> > 
> > Why exposing spinand_otp_read and spinand_otp_write ?  
> 
> For the SPI-NAND chips we have (Micron, ESMT, FORESEE), the command
> sequence for reading/writing OTP is the same. I decided to make these
> functions global because other chips probably have similar read/write
> OTP operations as well.

Of course, I understand you might need them, but then the change does
not belong to this patch. Actually you've done that correctly for the
spinand_wait() helper.

You can do all the "make foo() global" operations in a single patch if
you want.

I will soon review more in deep the content of this patchset again.

Thanks,
Miquèl