linux-kernel - Re: [PATCH net-next v2 1/3] net: dsa: microchip: rename ksz8 series files

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2f4884ff683c2ba7510f562f1a0f1c86ce6a0518.camel@microchip.com>
Date: Mon, 2 Sep 2024 14:30:35 +0000
From: <Arun.Ramadoss@...rochip.com>
To: <vtpieter@...il.com>
CC: <Tristram.Ha@...rochip.com>, <andrew@...n.ch>, <linux@...linux.org.uk>,
	<olteanv@...il.com>, <davem@...emloft.net>, <Woojung.Huh@...rochip.com>,
	<linux-kernel@...r.kernel.org>, <pieter.van.trappen@...n.ch>,
	<f.fainelli@...il.com>, <kuba@...nel.org>, <UNGLinuxDriver@...rochip.com>,
	<edumazet@...gle.com>, <o.rempel@...gutronix.de>, <netdev@...r.kernel.org>,
	<pabeni@...hat.com>
Subject: Re: [PATCH net-next v2 1/3] net: dsa: microchip: rename ksz8 series
 files

Hi Pieter,

On Mon, 2024-09-02 at 12:08 +0200, Pieter wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you
> know the content is safe
> 
> Hi Arun,
> 
> > > -         This driver adds support for Microchip KSZ9477 series
> > > switch and
> > > -         KSZ8795/KSZ88x3 switch chips.
> > > +         This driver adds support for Microchip KSZ9477 series,
> > > +         LAN937X series and KSZ8 series switch chips, being
> > > +         KSZ9477/9896/9897/9893/9563/9567,
> > 
> > You missed KSZ8567 and KSZ8563. Also it could be in order as
> > suggested
> > by Tristram,
> > -  KSZ8863/8873, KSZ8895/8864, KSZ8794/8795/8765
> > -  KSZ9477/9897/9896/9567/8567
> > -  KSZ9893/9563/8563
> > -  LAN9370/9371/9372/9373/9374
> 
> OK will do.
> 
> > > + * It supports the following switches:
> > > + * - KSZ8863, KSZ8873 aka KSZ88X3
> > > + * - KSZ8895, KSZ8864 aka KSZ8895 family
> > 
> > You can remove 'family' here, so as to be consistent.
> 
> Well I'd rather keep it so it's consistent with the ksz_common.h
> ksz_is_8895_family(), do you agree?

OK. LGTM.