linux-kernel - Re: [PATCH] iommu/tegra241-cmdqv: Fix -Wformat-truncation warnings in lvcmdq_error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <172527350346.3175637.9296819868165905950.b4-ty@kernel.org>
Date: Mon,  2 Sep 2024 16:17:34 +0100
From: Will Deacon <will@...nel.org>
To: Nicolin Chen <nicolinc@...dia.com>
Cc: catalin.marinas@....com,
	kernel-team@...roid.com,
	Will Deacon <will@...nel.org>,
	thierry.reding@...il.com,
	vdumpa@...dia.com,
	robin.murphy@....com,
	joro@...tes.org,
	jonathanh@...dia.com,
	linux-tegra@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org,
	iommu@...ts.linux.dev,
	linux-kernel@...r.kernel.org,
	Jason Gunthorpe <jgg@...pe.ca>
Subject: Re: [PATCH] iommu/tegra241-cmdqv: Fix -Wformat-truncation warnings in lvcmdq_error_header

On Sun, 01 Sep 2024 22:57:45 -0700, Nicolin Chen wrote:
> Kernel test robot reported a few trucation warnings at the snprintf:
> drivers/iommu/arm/arm-smmu-v3/tegra241-cmdqv.c:
> 	In function ‘tegra241_vintf_free_lvcmdq’:
> drivers/iommu/arm/arm-smmu-v3/tegra241-cmdqv.c:239:56:
> 	warning: ‘%u’ directive output may be truncated writing between 1 and
> 	5 bytes into a region of size between 3 and 11 [-Wformat-truncation=]
>   239 |         snprintf(header, hlen, "VINTF%u: VCMDQ%u/LVCMDQ%u: ",
>       |                                                        ^~
> drivers/iommu/arm/arm-smmu-v3/tegra241-cmdqv.c:239:32: note: directive argument
> 	in the range [0, 65535]
>   239 |         snprintf(header, hlen, "VINTF%u: VCMDQ%u/LVCMDQ%u: ",
>       |                                ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> drivers/iommu/arm/arm-smmu-v3/tegra241-cmdqv.c:239:9: note: ‘snprintf’ output
> 	between 25 and 37 bytes into a destination of size 32
>   239 |         snprintf(header, hlen, "VINTF%u: VCMDQ%u/LVCMDQ%u: ",
>       |         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>   240 |                  vcmdq->vintf->idx, vcmdq->idx, vcmdq->lidx);
> 
> [...]

Applied to will (for-joerg/arm-smmu/updates), thanks!

[1/1] iommu/tegra241-cmdqv: Fix -Wformat-truncation warnings in lvcmdq_error_header
      https://git.kernel.org/will/c/db184a1ced56

Cheers,
-- 
Will

https://fixes.arm64.dev
https://next.arm64.dev
https://will.arm64.dev