linux-kernel - Re: [PATCH 2/2] arm64: dts: qcom: x1e80100-romulus: Set up USB Multiport controller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7762a199-9091-46d7-a172-5cccc51a26e9@linaro.org>
Date: Mon, 2 Sep 2024 18:09:20 +0200
From: neil.armstrong@...aro.org
To: Konrad Dybcio <konradybcio@...nel.org>,
 Bjorn Andersson <andersson@...nel.org>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>
Cc: Marijn Suijten <marijn.suijten@...ainline.org>,
 linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org, Konrad Dybcio <quic_kdybcio@...cinc.com>,
 20240830-nxp-ptn3222-v2-0-4c6d8535cf6c@...aro.org
Subject: Re: [PATCH 2/2] arm64: dts: qcom: x1e80100-romulus: Set up USB
 Multiport controller

On 02/09/2024 18:07, Konrad Dybcio wrote:
> On 2.09.2024 6:01 PM, neil.armstrong@...aro.org wrote:
>> On 02/09/2024 16:50, Konrad Dybcio wrote:
>>> From: Konrad Dybcio <quic_kdybcio@...cinc.com>
>>>
>>> The USB MP controller is wired up to the USB-A port on the left side
>>> and to the Surface Connector on the right side. Configure it.
>>>
>>> While at it, remove a stray double \n.
>>>
>>> Signed-off-by: Konrad Dybcio <quic_kdybcio@...cinc.com>
>>> ---
>>>    .../boot/dts/qcom/x1e80100-microsoft-romulus.dtsi  | 59 +++++++++++++++++++++-
>>>    1 file changed, 57 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/arch/arm64/boot/dts/qcom/x1e80100-microsoft-romulus.dtsi b/arch/arm64/boot/dts/qcom/x1e80100-microsoft-romulus.dtsi
>>> index 5419d0b02785..ac2acf949b70 100644
>>> --- a/arch/arm64/boot/dts/qcom/x1e80100-microsoft-romulus.dtsi
>>> +++ b/arch/arm64/boot/dts/qcom/x1e80100-microsoft-romulus.dtsi
>>> @@ -572,7 +572,17 @@ &i2c5 {
>>>          status = "okay";
>>>    -    /* Something @4f */
>>> +    ptn3222: redriver@4f {
>>> +        compatible = "nxp,ptn3222";
>>> +        reg = <0x4f>;
>>> +
>>> +        reset-gpios = <&tlmm 7 GPIO_ACTIVE_LOW>;
>>> +
>>> +        vdd3v3-supply = <&vreg_l13b>;
>>> +        vdd1v8-supply = <&vreg_l4b>;
>>> +
>>> +        #phy-cells = <0>;
>>
>> It's unrelated to mutiport USB-A, should go in a separate change,
>> and also probably in a bigger change enabling usb-c features using
>> the retimer.
> 
> No, this chip converts between eUSB on the PHY and USB on the port

Oh my bad, indeed, sorry for the confusion

Neil

> 
> Konrad