linux-kernel - Re: AW: [PATCH 1/2] dt-bindings: hwmon: Introduce ADS71x8

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <513a6fd6-9985-4b4b-a501-47d331d71224@roeck-us.net>
Date: Mon, 2 Sep 2024 10:01:32 -0700
From: Guenter Roeck <linux@...ck-us.net>
To: Krzysztof Kozlowski <krzk@...nel.org>,
 "Sperling, Tobias" <Tobias.Sperling@...ting.com>
Cc: "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
 "linux-hwmon@...r.kernel.org" <linux-hwmon@...r.kernel.org>,
 "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
 "linux-doc@...r.kernel.org" <linux-doc@...r.kernel.org>,
 "jdelvare@...e.com" <jdelvare@...e.com>, "robh@...nel.org"
 <robh@...nel.org>, "krzk+dt@...nel.org" <krzk+dt@...nel.org>,
 "conor+dt@...nel.org" <conor+dt@...nel.org>, "corbet@....net"
 <corbet@....net>
Subject: Re: AW: [PATCH 1/2] dt-bindings: hwmon: Introduce ADS71x8

On 9/2/24 09:02, Krzysztof Kozlowski wrote:
> On 02/09/2024 15:48, Sperling, Tobias wrote:
>>> On Fri, Aug 30, 2024 at 11:49:53AM +0000, Sperling, Tobias wrote:
>>>> >From b2e04ce5500faf274654be5284be9db4f3abefce Mon Sep 17 00:00:00
>>> 2001
>>>
>>> Some junk ^^^ above. Please investigate how you send patches.
>>
>> Yeah also saw this line, but of course tried to apply the patch again after sending it
>> as mail and that worked fine. But just checked again and seems like this line can be
>> dropped.
>> And yes, I sent the patches manually, as we likely have some restrictions for smtp,
>> but as I was able to apply them again it's fine I guess.
>>
>>>> From: Tobias Sperling <tobias.sperling@...ting.com>
>>>> Date: Fri, 23 Aug 2024 12:08:33 +0200
>>>> Subject: [PATCH 1/2] dt-bindings: hwmon: Introduce ADS71x8
>>>
>>> And all this suggests malformed patch.
>>
>> Why? If I drop this I'm not able to apply the patch, so I think this should be fine.
> 
> OK, it works with b4, but seeing duplicated subject is not expected and
> might not work with all tools.
> 
>>
>>>>
>>>> Add documentation for the driver of ADS7128 and ADS7138 12-bit, 8-channel
>>>> analog-to-digital converters. These ADCs have a wide operating range and
>>>> a wide feature set. Communication is based on an I2C interface.
>>>> The driver provides the functionality of manually reading single channels
>>>> or sequentially reading all channels automatically.
>>>>
>>>> Signed-off-by: Tobias Sperling <tobias.sperling@...ting.com>
>>>> ---
>>>>   .../devicetree/bindings/hwmon/ti,ads71x8.yaml |  85 +++++++++++
>>>>   Documentation/hwmon/ads71x8.rst               | 140 ++++++++++++++++++
>>>>   Documentation/hwmon/index.rst                 |   1 +
>>>
>>> Please run scripts/checkpatch.pl and fix reported warnings. Then please
>>> run  and (probably) fix more warnings.
>>> Some warnings can be ignored, especially from --strict run, but the code
>>> here looks like it needs a fix. Feel free to get in touch if the warning
>>> is not clear.
>>
>> Had done this already before submitting the patches (at least without --strict),
>> but only reports a warning about splitting the patch (which I got wrong here)
>> and updating the maintainers.
>> I guess you were about suggesting a second script to run. Which one is that?
> 
> Please split the patches.
> 

I suspect you may have to be more specific. There need to be two patches
in Documentation/, one with the bindings and another one with the driver
documentation.

Thanks,
Guenter