linux-kernel - Re: [PATCH] watchdog: iTCO_wdt: Convert comma to semicolon

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2896d0a9-5e92-41d9-8dcb-c804ac2a606b@roeck-us.net>
Date: Mon, 2 Sep 2024 10:15:51 -0700
From: Guenter Roeck <linux@...ck-us.net>
To: Chen Ni <nichen@...as.ac.cn>, wim@...ux-watchdog.org,
 andy.shevchenko@...il.com
Cc: linux-watchdog@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] watchdog: iTCO_wdt: Convert comma to semicolon

On 9/2/24 01:10, Chen Ni wrote:
> Replace a comma between expression statements by a semicolon.
> 
> Fixes: ce1b95ca23c1 ("watchdog: iTCO_wdt: Use allocated data structures")
> Signed-off-by: Chen Ni <nichen@...as.ac.cn>
> ---

The patch is ok, but it doesn't _fix_ anything. The fixes tag should be dropped
when applying.

Reviewed-by: Guenter Roeck <linux@...ck-us.net>

Guenter


>   drivers/watchdog/iTCO_wdt.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/watchdog/iTCO_wdt.c b/drivers/watchdog/iTCO_wdt.c
> index 264857d314da..35b358bcf94c 100644
> --- a/drivers/watchdog/iTCO_wdt.c
> +++ b/drivers/watchdog/iTCO_wdt.c
> @@ -563,8 +563,8 @@ static int iTCO_wdt_probe(struct platform_device *pdev)
>   	}
>   
>   	ident.firmware_version = p->iTCO_version;
> -	p->wddev.info = &ident,
> -	p->wddev.ops = &iTCO_wdt_ops,
> +	p->wddev.info = &ident;
> +	p->wddev.ops = &iTCO_wdt_ops;
>   	p->wddev.bootstatus = 0;
>   	p->wddev.timeout = WATCHDOG_TIMEOUT;
>   	watchdog_set_nowayout(&p->wddev, nowayout);