linux-kernel - Re: [PATCH v2 6/8] dt-bindings: iio: adc: document diff-channels corner case for some ADCs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+GgBR_uO-qOP8mRCmWdhEFMJRz4KvVvpx2tVVsZy2iZCvPD-w@mail.gmail.com>
Date: Mon, 2 Sep 2024 21:28:48 +0300
From: Alexandru Ardelean <aardelean@...libre.com>
To: Krzysztof Kozlowski <krzk@...nel.org>
Cc: linux-iio@...r.kernel.org, linux-kernel@...r.kernel.org, 
	devicetree@...r.kernel.org, jic23@...nel.org, krzk+dt@...nel.org, 
	robh@...nel.org, lars@...afoo.de, michael.hennerich@...log.com, 
	gstols@...libre.com
Subject: Re: [PATCH v2 6/8] dt-bindings: iio: adc: document diff-channels
 corner case for some ADCs

On Mon, Sep 2, 2024 at 2:54 PM Krzysztof Kozlowski <krzk@...nel.org> wrote:
>
> On Mon, Sep 02, 2024 at 01:36:29PM +0300, Alexandru Ardelean wrote:
> > Some ADCs have channels with negative and positive inputs, which can be
> > used to measure differential voltage levels. These inputs/pins are
> > dedicated (to the given channel) and cannot be muxed as with other ADCs.
> >
> > For those types of setups, the 'diff-channels' property can be specified to
> > be used with the channel number (or reg property) for both negative and
> > positive inputs/pins.
> >
> > Signed-off-by: Alexandru Ardelean <aardelean@...libre.com>
> > ---
> >  Documentation/devicetree/bindings/iio/adc/adc.yaml | 4 ++++
> >  1 file changed, 4 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/iio/adc/adc.yaml b/Documentation/devicetree/bindings/iio/adc/adc.yaml
> > index 8e7835cf36fd..9b7a8e149639 100644
> > --- a/Documentation/devicetree/bindings/iio/adc/adc.yaml
> > +++ b/Documentation/devicetree/bindings/iio/adc/adc.yaml
> > @@ -37,6 +37,10 @@ properties:
> >        to both the positive and negative inputs of a differential ADC.
> >        The first value specifies the positive input pin, the second
> >        specifies the negative input pin.
> > +      There are also some ADCs, where the differential channel has dedicated
> > +      positive and negative inputs which can be used to measure differential
> > +      voltage levels. For those setups, this property can be configured with
> > +      the the 'reg' property (i.e. diff-channels = <reg reg>).
>
> Please run scripts/checkpatch.pl and fix reported warnings. Then please
> run  and (probably) fix more warnings.
> Some warnings can be ignored, especially from --strict run, but the code
> here looks like it needs a fix. Feel free to get in touch if the warning
> is not clear.

Right.
Will fix.
Seems checkpatch.pl is able to catch my stutter.

>
> Best regards,
> Krzysztof
>