linux-kernel - Re: linux-next: Fixes tag needs some work in the perf-current tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZtYHGDaoJrwLgs--@x1>
Date: Mon, 2 Sep 2024 15:42:32 -0300
From: Arnaldo Carvalho de Melo <acme@...nel.org>
To: Namhyung Kim <namhyung@...nel.org>,
	Stephen Rothwell <sfr@...b.auug.org.au>
Cc: Arnaldo Carvalho de Melo <arnaldo.melo@...il.com>,
	Veronika Molnarova <vmolnaro@...hat.com>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Linux Next Mailing List <linux-next@...r.kernel.org>
Subject: Re: linux-next: Fixes tag needs some work in the perf-current tree

On Mon, Sep 02, 2024 at 08:18:37AM +1000, Stephen Rothwell wrote:
> Hi all,
> 
> In commit
> 
>   387ad33e5410 ("perf test pmu: Set uninitialized PMU alias to null")
> 
> Fixes tag
> 
>   Fixes: 3e0bf9 ("perf pmu: Restore full PMU name wildcard support")

In the perf-tools-next I have it as:

commit 37e2a19c98bf99747ca997be876dfc13f9165e0a
Author: Veronika Molnarova <vmolnaro@...hat.com>
Date:   Thu Aug 8 12:37:49 2024 +0200

    perf test pmu: Set uninitialized PMU alias to null
    
    Commit 3e0bf9fde2984469 ("perf pmu: Restore full PMU name wildcard
    support") adds a test case "PMU cmdline match" that covers PMU name
    wildcard support provided by function perf_pmu__match().
<SNIP>
    Fixes: 3e0bf9fde2984469 ("perf pmu: Restore full PMU name wildcard support")
    Signed-off-by: Veronika Molnarova <vmolnaro@...hat.com>
    Cc: James Clark <james.clark@...aro.org>
    Cc: Michael Petlan <mpetlan@...hat.com>
    Cc: Namhyung Kim <namhyung@...nel.org>
    Cc: Radostin Stoyanov <rstoyano@...hat.com>
    Link: https://lore.kernel.org/r/20240808103749.9356-1-vmolnaro@redhat.com
    Signed-off-by: Arnaldo Carvalho de Melo <acme@...hat.com>

As I have:

⬢[acme@...lbox perf-tools-next]$ git config core.abbrev
16
⬢[acme@...lbox perf-tools-next]$

And scripts to make sure we get enough resolution to avoid such problems

I just checked and yeah, on perf-tools/perf-tools it is:

    Fixes: 3e0bf9 ("perf pmu: Restore full PMU name wildcard support")
    Signed-off-by: Veronika Molnarova <vmolnaro@...hat.com>
    Cc: james.clark@....com
    Cc: mpetlan@...hat.com
    Cc: rstoyano@...hat.com
    Link: https://lore.kernel.org/r/20240808103749.9356-1-vmolnaro@redhat.com
    Signed-off-by: Namhyung Kim <namhyung@...nel.org>

So I suggest Namhyung fixes up the Fixes tag to have a longer prefix for
the sha and Veronica to run:

⬢[acme@...lbox perf-tools]$ git config core.abbrev 16
⬢[acme@...lbox perf-tools]$ git config core.abbrev
16
⬢[acme@...lbox perf-tools]$ 

- Arnaldo

 
> has these problem(s):
> 
>   - Target SHA1 does not exist
> 
> Actually, the quoted SHA1 is too short and is ambiguous in my tree:
> 
> $ git show 3e0bf9
> error: short object ID 3e0bf9 is ambiguous
> hint: The candidates are:
> hint:   3e0bf9fde298 commit 2024-06-26 - perf pmu: Restore full PMU name wildcard support
> hint:   3e0bf93e0354 tree
> fatal: ambiguous argument '3e0bf9': unknown revision or path not in the working tree.
> 
> so you should use
> 
> Fixes: 3e0bf9fde298 ("perf pmu: Restore full PMU name wildcard support")
> 
> -- 
> Cheers,
> Stephen Rothwell