[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20240902190620.GM23170@kernel.org>
Date: Mon, 2 Sep 2024 20:06:20 +0100
From: Simon Horman <horms@...nel.org>
To: Jinjie Ruan <ruanjinjie@...wei.com>
Cc: alexanderduyck@...com, kuba@...nel.org, davem@...emloft.net,
edumazet@...gle.com, pabeni@...hat.com, andrew@...n.ch,
kernel-team@...a.com, netdev@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH] eth: fbnic: Fix modpost undefined error
On Mon, Sep 02, 2024 at 09:19:47PM +0800, Jinjie Ruan wrote:
> When CONFIG_FBNIC=m, the following error occurs:
>
> ERROR: modpost: "priv_to_devlink" [drivers/net/ethernet/meta/fbnic/fbnic.ko] undefined!
> ERROR: modpost: "page_pool_create" [drivers/net/ethernet/meta/fbnic/fbnic.ko] undefined!
> ERROR: modpost: "devlink_info_serial_number_put" [drivers/net/ethernet/meta/fbnic/fbnic.ko] undefined!
> ERROR: modpost: "page_pool_alloc_pages" [drivers/net/ethernet/meta/fbnic/fbnic.ko] undefined!
> ERROR: modpost: "devlink_priv" [drivers/net/ethernet/meta/fbnic/fbnic.ko] undefined!
> ERROR: modpost: "page_pool_put_unrefed_page" [drivers/net/ethernet/meta/fbnic/fbnic.ko] undefined!
> ERROR: modpost: "devlink_unregister" [drivers/net/ethernet/meta/fbnic/fbnic.ko] undefined!
> ERROR: modpost: "devlink_alloc_ns" [drivers/net/ethernet/meta/fbnic/fbnic.ko] undefined!
> ERROR: modpost: "devlink_register" [drivers/net/ethernet/meta/fbnic/fbnic.ko] undefined!
> ERROR: modpost: "devlink_free" [drivers/net/ethernet/meta/fbnic/fbnic.ko] undefined!
>
> The driver now uses functions exported from a helper module
> but fails to link when the helper is disabled, select them to fix them
>
> Fixes: 546dd90be979 ("eth: fbnic: Add scaffolding for Meta's NIC driver")
> Signed-off-by: Jinjie Ruan <ruanjinjie@...wei.com>
Thanks,
I believe a patch for this problem is already present upstream.
- 9a95b7a89dff ("eth: fbnic: select DEVLINK and PAGE_POOL")
https://git.kernel.org/netdev/net-next/c/9a95b7a89dff
--
pw-bot: not-applicable
Powered by blists - more mailing lists