linux-kernel - Re: [PATCH 2/2] driver core: class: warn if a compatibility class is registered

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2024090242-smother-preview-a1d2@gregkh>
Date: Mon, 2 Sep 2024 21:20:13 +0200
From: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To: Heiner Kallweit <hkallweit1@...il.com>
Cc: Wolfram Sang <wsa@...nel.org>, "Rafael J. Wysocki" <rafael@...nel.org>,
	"linux-i2c@...r.kernel.org" <linux-i2c@...r.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 2/2] driver core: class: warn if a compatibility class is
 registered

On Mon, Sep 02, 2024 at 09:02:17PM +0200, Heiner Kallweit wrote:
> Kernel doc for this function states:
> "Compatibility class are meant as a temporary user-space compatibility
> workaround when converting a family of class devices to a bus devices."
> 
> Therefore remind any potential user of the old ABI that support for it
> will be dropped soon.
> 
> Signed-off-by: Heiner Kallweit <hkallweit1@...il.com>
> ---
>  drivers/base/class.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/base/class.c b/drivers/base/class.c
> index 7b38fdf8e..f12a43736 100644
> --- a/drivers/base/class.c
> +++ b/drivers/base/class.c
> @@ -556,6 +556,9 @@ struct class_compat *class_compat_register(const char *name)
>  {
>  	struct class_compat *cls;
>  
> +	pr_warn("Compatibility class %s will go away soon, please migrate userspace tools to use bus devices\n",
> +		name);

That's not going to do anything except annoy users who have no control
over this, sorry.  Please just fix up all of the kernel and then delete
this function.

thanks,

greg k-h