linux-kernel - Re: [PATCH v2 1/4] mm: Add optional close() to struct vm_special

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHk-=wjD0XLhkzou89J-TK=L6B88pFoNYxN1uTWRQB3U5Czywg@mail.gmail.com>
Date: Mon, 2 Sep 2024 14:02:56 -0700
From: Linus Torvalds <torvalds@...ux-foundation.org>
To: Andrew Morton <akpm@...ux-foundation.org>
Cc: Sven Schnelle <svens@...ux.ibm.com>, Nathan Chancellor <nathan@...nel.org>, 
	Michael Ellerman <mpe@...erman.id.au>, linux-mm@...ck.org, linuxppc-dev@...ts.ozlabs.org, 
	christophe.leroy@...roup.eu, jeffxu@...gle.com, Liam.Howlett@...cle.com, 
	linux-kernel@...r.kernel.org, npiggin@...il.com, oliver.sang@...el.com, 
	pedro.falcato@...il.com, linux-um@...ts.infradead.org, 
	linux-s390@...r.kernel.org, Ravi Bangoria <ravi.bangoria@...ux.ibm.com>, 
	Steven Rostedt <rostedt@...dmis.org>
Subject: Re: [PATCH v2 1/4] mm: Add optional close() to struct vm_special_mapping

On Mon, 2 Sept 2024 at 13:49, Andrew Morton <akpm@...ux-foundation.org> wrote:
>
> uprobe_clear_state() is a pretty simple low-level thing.  Side-effects
> seem unlikely?

I think uprobe_clear_state() should be removed from fork.c entirely,
made 'static', and then we'd have

        area->xol_mapping.close = uprobe_clear_state;

in __create_xol_area() instead (ok, the arguments change, instead of
looking up "mm->uprobes_state.xol_area", it would get it as the vma
argument)

That's how it should always have been, except we didn't have a close() function.

Hmm?

            Linus