linux-kernel - Re: [PATCH v9 2/5] arm64: ptdump: Expose the attribute parsing functionality

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZtVO9VDe-26jQFUK@google.com>
Date: Mon, 2 Sep 2024 05:36:53 +0000
From: Sebastian Ene <sebastianene@...gle.com>
To: Marc Zyngier <maz@...nel.org>
Cc: akpm@...ux-foundation.org, alexghiti@...osinc.com, ankita@...dia.com,
	ardb@...nel.org, catalin.marinas@....com,
	christophe.leroy@...roup.eu, james.morse@....com,
	vdonnefort@...gle.com, mark.rutland@....com, oliver.upton@...ux.dev,
	rananta@...gle.com, ryan.roberts@....com, shahuang@...hat.com,
	suzuki.poulose@....com, will@...nel.org, yuzenghui@...wei.com,
	kvmarm@...ts.linux.dev, linux-arm-kernel@...ts.infradead.org,
	linux-kernel@...r.kernel.org, kernel-team@...roid.com
Subject: Re: [PATCH v9 2/5] arm64: ptdump: Expose the attribute parsing
 functionality

On Fri, Aug 30, 2024 at 01:28:36PM +0100, Marc Zyngier wrote:
> On Tue, 27 Aug 2024 09:45:45 +0100,
> Sebastian Ene <sebastianene@...gle.com> wrote:
> > 
> > Reuse the descriptor parsing functionality to keep the same output format
> > as the original ptdump code.

Hello Mark,

> 
> This sentence seems either out of place or missing something, because
> this change it not reusing anything...
> 
> > In order for this to happen, move the state
> > tracking objects into a common header.
> 
> ... but instead doing this ^^^.
> 
> I propose to rewrite the commit message as:
> 
> "Adding a new page-table dumper for stage-2 requires parsing the page
> tables, and reusing the descriptor parsing functionality would help
> keeping the same output format as the original ptdump code.
> 
> In order for this to happen, move the state tracking object
> definitions into a common header."

Thanks for the feedback, I think the re-wording works much better and
I'll make use of it.

> 
> Shout if you object to it!
> 
> Thanks,
> 
> 	M.
>

Seb

> -- 
> Without deviation from the norm, progress is not possible.