linux-kernel - Re: [PATCH 1/2] ALSA: usb-audio: Add quirk for RME Digiface USB

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8734mik2m6.wl-tiwai@suse.de>
Date: Mon, 02 Sep 2024 08:10:09 +0200
From: Takashi Iwai <tiwai@...e.de>
To: Asahi Lina <lina@...hilina.net>
Cc: Jaroslav Kysela <perex@...ex.cz>,
	Takashi Iwai <tiwai@...e.com>,
	"Geoffrey D. Bennett" <g@...vu>,
	Takashi Sakamoto <o-takashi@...amocchi.jp>,
	Mark Hills <mark@...x.org>,
	Arun Raghavan <arun@...nraghavan.net>,
	Cyan Nyan <cyan.vtb@...il.com>,
	linux-sound@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] ALSA: usb-audio: Add quirk for RME Digiface USB

On Sun, 01 Sep 2024 23:31:50 +0200,
Asahi Lina wrote:
> 
> From: Cyan Nyan <cyan.vtb@...il.com>
> 
> Add trivial support for audio streaming on the RME Digiface USB. Binds
> only to the first interface to allow userspace to directly drive the
> complex I/O and matrix mixer controls.
> 
> Signed-off-by: Cyan Nyan <cyan.vtb@...il.com>
> [Lina: Added 2x/4x sample rate support & boot/format quirks]
> Co-developed-by: Asahi Lina <lina@...hilina.net>
> Signed-off-by: Asahi Lina <lina@...hilina.net>
> ---
>  sound/usb/quirks-table.h | 190 ++++++++++++++++++++++++++++++++++++++++++++++-
>  sound/usb/quirks.c       |  58 +++++++++++++++
>  2 files changed, 247 insertions(+), 1 deletion(-)
> 
> diff --git a/sound/usb/quirks-table.h b/sound/usb/quirks-table.h
> index 73abc38a5400..47fd18791396 100644
> --- a/sound/usb/quirks-table.h
> +++ b/sound/usb/quirks-table.h
> @@ -4546,6 +4546,194 @@ YAMAHA_DEVICE(0x7010, "UB99"),
>  		}
>  	}
>  },
> -
> +{
> +	/* Only claim interface 0 */
> +	.match_flags = USB_DEVICE_ID_MATCH_VENDOR |
> +		       USB_DEVICE_ID_MATCH_PRODUCT |
> +		       USB_DEVICE_ID_MATCH_INT_CLASS |
> +		       USB_DEVICE_ID_MATCH_INT_NUMBER,
> +	.idVendor = 0x2a39,
> +	.idProduct = 0x3f8c,
> +	.bInterfaceClass = USB_CLASS_VENDOR_SPEC,
> +	.bInterfaceNumber = 0,
> +	.driver_info = (unsigned long) &(const struct snd_usb_audio_quirk) {
> +		.ifnum = QUIRK_ANY_INTERFACE,
> +		.type = QUIRK_COMPOSITE,
(snip)

Recently the quirk tables are rewritten with macros.
See the commit d79e13f8e8abb5cd3a2a0f9fc9bc3fc750c5b06f
    ALSA: usb-audio: Replace complex quirk lines with macros
in for-next branch of sound.git tree.

Could you try to apply to your new entries, too?


thanks,

Takashi