linux-kernel - Re: [PATCH 2/2] erofs: use kmemdup_nul in erofs_fill

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <xevmwnwrovlcueuxawmpse545faxoky5nbqlkpzebq7eajr3kr@khnm5umjvctk>
Date: Mon, 2 Sep 2024 14:52:00 +0800
From: Yiyang Wu <toolmanp@...p.cc>
To: Gao Xiang <hsiangkao@...ux.alibaba.com>
Cc: linux-erofs@...ts.ozlabs.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] erofs: use kmemdup_nul in erofs_fill_symlink

On Mon, Sep 02, 2024 at 01:46:44PM GMT, Gao Xiang wrote:
> Hi Yiyang,
> 
> On 2024/9/2 12:51, Yiyang Wu wrote:
> > Remove open coding in erofs_fill_symlink.
> > 
> > Suggested-by: Al Viro <viro@...iv.linux.org.uk>
> > Link: https://lore.kernel.org/all/20240425222847.GN2118490@ZenIV
> > Signed-off-by: Yiyang Wu <toolmanp@...p.cc>
> 
> Could we lift this patch as [PATCH 1/2]?
> 
No problem, it's fine to me.
> 
> 	lnk = kmemdup_nul(kaddr + m_pofs, inode->i_size, GFP_KERNEL);
> 
> Missing blank here.
Fixed, thanks for pointing out.
> 
> Thanks,
> Gao Xiang

Best Regards,
Yiyang Wu