[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <l2xjrs7txycf3uhhhyzypfzoem2fr4fsvbyg3bt4ktfpbzxz47@loiytha55oml>
Date: Mon, 2 Sep 2024 09:11:05 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Frank Li <Frank.Li@....com>
Cc: Rob Herring <robh@...nel.org>, Conor Dooley <conor+dt@...nel.org>,
Michael Walle <mwalle@...nel.org>, Shawn Guo <shawnguo@...nel.org>,
"open list:MEMORY CONTROLLER DRIVERS" <linux-kernel@...r.kernel.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" <devicetree@...r.kernel.org>, imx@...ts.linux.dev
Subject: Re: [PATCH v3 1/1] dt-bindings: memory-controllers: fsl,ifc: add
compatible string fsl,ifc-nand
On Fri, Aug 30, 2024 at 03:11:43PM -0400, Frank Li wrote:
> ifc can connect nor, nand and fpag. Add child node "nand@" under fsl,ifc
> and compatible string "fsl,ifc-nand" when ifc connect to nand flash.
>
> Fix below warning:
> arch/arm64/boot/dts/freescale/fsl-ls1043a-qds.dtb: /soc/memory-controller@...0000/nand@1,0:
> failed to match any schema with compatible: ['fsl,ifc-nand']
>
> Signed-off-by: Frank Li <Frank.Li@....com>
> ---
> Change from v2 to v3
> - add partition child node for nand
> - Only partition property is used at ppc
> Change from v1 to v2
> - add address-cells and size-cells
> ---
> .../memory-controllers/fsl/fsl,ifc.yaml | 26 +++++++++++++++++++
> 1 file changed, 26 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/memory-controllers/fsl/fsl,ifc.yaml b/Documentation/devicetree/bindings/memory-controllers/fsl/fsl,ifc.yaml
> index d1c3421bee107..5a11224da8914 100644
> --- a/Documentation/devicetree/bindings/memory-controllers/fsl/fsl,ifc.yaml
> +++ b/Documentation/devicetree/bindings/memory-controllers/fsl/fsl,ifc.yaml
> @@ -58,6 +58,32 @@ properties:
> access window as configured.
>
> patternProperties:
> + "^nand@[a-f0-9]+(,[a-f0-9]+)+$":
> + type: object
> + properties:
> + compatible:
> + const: fsl,ifc-nand
> +
> + reg:
> + maxItems: 1
> +
> + "#address-cells":
> + const: 1
> +
> + "#size-cells":
> + const: 1
> +
> + patternProperties:
> + "^partition@[0-9a-f]+":
> + $ref: /schemas/mtd/partitions/partition.yaml#
> + deprecated: true
> +
> + required:
> + - compatible
> + - reg
> +
> + additionalProperties: false
> +
> "^.*@[a-f0-9]+(,[a-f0-9]+)+$":
This pattern is for NAND already. I don't understand why you are
duplicating it. If this part does not work, fix it.
Best regards,
Krzysztof
Powered by blists - more mailing lists