linux-kernel - Re: [PATCH v2 2/2] dt-bindings: arm: fsl: Add Variscite Symphony board and VAR-SOM-MX8MP SoM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <taacgew4rjjh6q53pog4jv2waamso7ytor5a2womrm3txowjo3@t3yimdusgc6g>
Date: Mon, 2 Sep 2024 09:14:00 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Tarang Raval <tarang.raval@...iconsignals.io>
Cc: Conor Dooley <conor+dt@...nel.org>, 
	Sascha Hauer <s.hauer@...gutronix.de>, Pengutronix Kernel Team <kernel@...gutronix.de>, 
	Hugo Villeneuve <hvilleneuve@...onoff.com>, Gregor Herburger <gregor.herburger@...tq-group.com>, 
	Joao Paulo Goncalves <joao.goncalves@...adex.com>, Hiago De Franco <hiago.franco@...adex.com>, 
	Mathieu Othacehe <m.othacehe@...il.com>, Alexander Stein <alexander.stein@...tq-group.com>, 
	Josua Mayer <josua@...id-run.com>, Yannic Moog <y.moog@...tec.de>, Li Yang <leoyang.li@....com>, 
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, 
	"imx@...ts.linux.dev" <imx@...ts.linux.dev>, 
	"linux-arm-kernel@...ts.infradead.org" <linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH v2 2/2] dt-bindings: arm: fsl: Add Variscite Symphony
 board and VAR-SOM-MX8MP SoM

On Mon, Sep 02, 2024 at 07:07:02AM +0000, Tarang Raval wrote:
> Hi,
> 
> >>                - toradex,verdin-imx8mp-wifi  # Verdin iMX8M Plus Wi-Fi / BT Modules
> >> +              - variscite,var-som-mx8mp-symphony # i.MX8MP Variscite VAR-SOM-MX8M-PLUS Symphony evaluation board
> >>            - const: fsl,imx8mp
> >
> ><form letter>
> >This is a friendly reminder during the review process.
> >
> > It seems my or other reviewer's previous comments were not fully
> addressed. Maybe the feedback got lost between the quotes, maybe you
> just forgot to apply it. Please go back to the previous discussion and
> either implement all requested changes or keep discussing them.
> 
> as per your comment, I did update the board name to "variscite,var-som-mx8mp-symphony" instead of "variscite,var-som-mx8mp."

??? No, there is no difference. You did not test your patches either.

When I wrote "This is not correct", it means you should drop it.
Incorrect compatibles should not be added.

Best regards,
Krzysztof