linux-kernel - Re: [RFC PATCH] dt-bindings: arm: marvell: convert armada-375.txt to yaml

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <j6sunewrzzeu7yuo7c7vcvjvlku737tgwtemyo3tfjdfsaowtu@cf6dbrp5prpi>
Date: Mon, 2 Sep 2024 09:24:18 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Aryabhatta Dey <aryabhattadey35@...il.com>
Cc: andrew@...n.ch, gregory.clement@...tlin.com, 
	sebastian.hesselbarth@...il.com, robh@...nel.org, krzk+dt@...nel.org, conor+dt@...nel.org, 
	linux-arm-kernel@...ts.infradead.org, devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [RFC PATCH] dt-bindings: arm: marvell: convert armada-375.txt to
 yaml

On Mon, Sep 02, 2024 at 07:53:43AM +0530, Aryabhatta Dey wrote:
> Convert dt-binding armada-375 from txt to yaml format.
> 
> Signed-off-by: Aryabhatta Dey <aryabhattadey35@...il.com>

> diff --git a/Documentation/devicetree/bindings/arm/marvell/armada-375.yaml b/Documentation/devicetree/bindings/arm/marvell/armada-375.yaml
> new file mode 100644
> index 000000000000..d56d3d6d40d0
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/arm/marvell/armada-375.yaml
> @@ -0,0 +1,23 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/arm/marvell/armada-375.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Marvell Armada 375 Platforms
> +
> +maintainers:
> +  - Aryabhatta Dey <aryabhattadey35@...il.com>

No, I don't think you maintain the platforms. Do you have the hardware?
Which one?

> +
> +properties:
> +  $nodename:
> +    const: '/'
> +  compatible:
> +    oneOf:
> +
> +      - description:
> +          Marvell Armada 375
> +        items:
> +          - const: marvell,armada375

That's not a correct list. SoC cannot be used alone.

Armada needs proper fixes, not just doing conversion to satisfy
conversion.

Best regards,
Krzysztof