linux-kernel - Re: [PATCH 4/4] ARM: dts: imx6qdl: align pin config nodes with bindings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <0035a39c-4e9e-4ffd-84f3-dea4835e95c0@linaro.org>
Date: Mon, 2 Sep 2024 09:55:31 +0200
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: Shawn Guo <shawnguo2@...h.net>
Cc: Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>, Shawn Guo <shawnguo@...nel.org>,
 Sascha Hauer <s.hauer@...gutronix.de>,
 Pengutronix Kernel Team <kernel@...gutronix.de>,
 Fabio Estevam <festevam@...il.com>, devicetree@...r.kernel.org,
 imx@...ts.linux.dev, linux-arm-kernel@...ts.infradead.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH 4/4] ARM: dts: imx6qdl: align pin config nodes with
 bindings

On 02/09/2024 03:05, Shawn Guo wrote:
> On Sat, Aug 31, 2024 at 12:28:21PM +0200, Krzysztof Kozlowski wrote:
>> Bindings for other NXP pin controllers expect pin configuration nodes in
>> pinctrl to match certain naming, so adjust these as well, even though
>> their bindings are not yet in dtschema format.
>>
>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
>> ---


>>  
>> -	pinctrl_usdhc1_200mhz: usdhc1grp200mhz {
>> +	pinctrl_usdhc1_200mhz: usdhc1-200mhz-grp {
>>  		fsl,pins = <
>>  			MX6QDL_PAD_SD1_CMD__SD1_CMD	0x170F9
>>  			MX6QDL_PAD_SD1_CLK__SD1_CLK	0x100F9
>> diff --git a/arch/arm/boot/dts/nxp/imx/imx6qdl-var-som.dtsi b/arch/arm/boot/dts/nxp/imx/imx6qdl-var-som.dtsi
>> index a1ea33c4eeb7..79d80632ee45 100644
>> --- a/arch/arm/boot/dts/nxp/imx/imx6qdl-var-som.dtsi
>> +++ b/arch/arm/boot/dts/nxp/imx/imx6qdl-var-som.dtsi
>> @@ -436,7 +436,7 @@ MX6QDL_PAD_SD3_RST__GPIO7_IO08  0x13059
>>  		>;
>>  	};
>>  
>> -	pinctrl_usdhc3_100mhz: usdhc3grp100mhzgrp {
>> +	pinctrl_usdhc3_100mhz: usdhc3-100mhz-grpgrp {
> 
> s/grpgrp/grp?
> 
>>  		fsl,pins = <
>>  			MX6QDL_PAD_SD3_CMD__SD3_CMD	0x170B9
>>  			MX6QDL_PAD_SD3_CLK__SD3_CLK	0x100B9
>> @@ -451,7 +451,7 @@ MX6QDL_PAD_SD3_RST__GPIO7_IO08  0x130B9
>>  		>;
>>  	};
>>  
>> -	pinctrl_usdhc3_200mhz: usdhc3grp200mhzgrp {
>> +	pinctrl_usdhc3_200mhz: usdhc3-200mhz-grpgrp {
> 
> Ditto
> 

Indeed, Thanks. I'll check if I did not make same mistake in other places.

Best regards,
Krzysztof