linux-kernel - Re: [PATCH RESEND] drm/imagination: Free pvr_vm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <55dfb0fe2a3996226e814b6f42014dba76cfa3e1.camel@imgtec.com>
Date: Mon, 2 Sep 2024 07:57:23 +0000
From: Frank Binns <Frank.Binns@...tec.com>
To: "tzimmermann@...e.de" <tzimmermann@...e.de>,
        Matt Coster
	<Matt.Coster@...tec.com>,
        "dri-devel@...ts.freedesktop.org"
	<dri-devel@...ts.freedesktop.org>,
        "airlied@...il.com" <airlied@...il.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "maarten.lankhorst@...ux.intel.com" <maarten.lankhorst@...ux.intel.com>,
        "daniel@...ll.ch" <daniel@...ll.ch>,
        "mripard@...nel.org"
	<mripard@...nel.org>
Subject: Re: [PATCH RESEND] drm/imagination: Free pvr_vm_gpuva after unlink

On Fri, 2024-08-30 at 15:07 +0000, Matt Coster wrote:
> This caused a measurable memory leak. Although the individual
> allocations are small, the leaks occurs in a high-usage codepath
> (remapping or unmapping device memory) so they add up quickly.
> 

Reviewed-by: Frank Binns <frank.binns@...tec.com>

> Signed-off-by: Matt Coster <matt.coster@...tec.com>
> Fixes: ff5f643de0bf ("drm/imagination: Add GEM and VM related code")
> Cc: stable@...r.kernel.org
> ---
>  drivers/gpu/drm/imagination/pvr_vm.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/drivers/gpu/drm/imagination/pvr_vm.c b/drivers/gpu/drm/imagination/pvr_vm.c
> index e59517ba039e..97c0f772ed65 100644
> --- a/drivers/gpu/drm/imagination/pvr_vm.c
> +++ b/drivers/gpu/drm/imagination/pvr_vm.c
> @@ -114,6 +114,8 @@ struct pvr_vm_gpuva {
>  	struct drm_gpuva base;
>  };
>  
> +#define to_pvr_vm_gpuva(va) container_of_const(va, struct pvr_vm_gpuva, base)
> +
>  enum pvr_vm_bind_type {
>  	PVR_VM_BIND_TYPE_MAP,
>  	PVR_VM_BIND_TYPE_UNMAP,
> @@ -386,6 +388,7 @@ pvr_vm_gpuva_unmap(struct drm_gpuva_op *op, void *op_ctx)
>  
>  	drm_gpuva_unmap(&op->unmap);
>  	drm_gpuva_unlink(op->unmap.va);
> +	kfree(to_pvr_vm_gpuva(op->unmap.va));
>  
>  	return 0;
>  }
> @@ -433,6 +436,7 @@ pvr_vm_gpuva_remap(struct drm_gpuva_op *op, void *op_ctx)
>  	}
>  
>  	drm_gpuva_unlink(op->remap.unmap->va);
> +	kfree(to_pvr_vm_gpuva(op->remap.unmap->va));
>  
>  	return 0;
>  }