[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <CACRpkdZqj7-mxCBBoWZm5QAVfNhak6PdrMnSmUWRKb6DpJLQNA@mail.gmail.com>
Date: Mon, 2 Sep 2024 10:04:33 +0200
From: Linus Walleij <linus.walleij@...aro.org>
To: Arnd Bergmann <arnd@...nel.org>, netdev <netdev@...r.kernel.org>,
Jakub Kicinski <kuba@...nel.org>, "David S. Miller" <davem@...emloft.net>
Cc: Andrew Lunn <andrew@...n.ch>, Florian Fainelli <f.fainelli@...il.com>,
Vladimir Oltean <olteanv@...il.com>, Arnd Bergmann <arnd@...db.de>,
Alvin Šipraga <alsi@...g-olufsen.dk>,
Eric Dumazet <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>,
Luiz Angelo Daros de Luca <luizluca@...il.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net: dsa: realtek: add LEDS_CLASS dependency
Hi David/Jakub,
On Tue, May 28, 2024 at 2:04 PM Arnd Bergmann <arnd@...nel.org> wrote:
> From: Arnd Bergmann <arnd@...db.de>
>
> This driver fails to link when LED support is disabled:
>
> ERROR: modpost: "led_init_default_state_get" [drivers/net/dsa/realtek/rtl8366.ko] undefined!
> ERROR: modpost: "devm_led_classdev_register_ext" [drivers/net/dsa/realtek/rtl8366.ko] undefined!
>
> Add a dependency that prevents this configuration.
>
> Fixes: 32d617005475 ("net: dsa: realtek: add LED drivers for rtl8366rb")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
Can you please apply this patch, the buildbots keep complaining about this,
and we agreed (I think) to take this dependency approach for now.
Yours,
Linus Walleij
Powered by blists - more mailing lists