linux-kernel - Re: [PATCH V2] Documentation: Improve crash_kexec_post_notifiers description

Open Source and information security mailing list archives

Message-ID: <20240902082342.GC23170@kernel.org>
Date: Mon, 2 Sep 2024 09:23:42 +0100
From: Simon Horman <horms@...nel.org>
To: "Guilherme G. Piccoli" <gpiccoli@...lia.com>
Cc: kexec@...ts.infradead.org, linux-doc@...r.kernel.org, bhe@...hat.com,
	corbet@....net, kernel@...ccoli.net, linux-kernel@...r.kernel.org,
	stephen.s.brennan@...cle.com, kernel-dev@...lia.com,
	dyoung@...hat.com, vgoyal@...hat.com,
	linux-debuggers@...r.kernel.org
Subject: Re: [PATCH V2] Documentation: Improve crash_kexec_post_notifiers
 description

On Fri, Aug 30, 2024 at 03:21:00PM -0300, Guilherme G. Piccoli wrote:
> Be more clear about the downsides, the upsides (yes, there are some!)
> and about code that unconditionally sets that.
> 
> Reviewed-by: Stephen Brennan <stephen.s.brennan@...cle.com>
> Signed-off-by: Guilherme G. Piccoli <gpiccoli@...lia.com>
> 
> ---
> 
> V2: Some wording improvements from Stephen, thanks!
> Also added his review tag.
> 
> V1 link: https://lore.kernel.org/r/20240830140401.458542-1-gpiccoli@igalia.com/
> 
> 
>  Documentation/admin-guide/kernel-parameters.txt | 16 ++++++++++------
>  1 file changed, 10 insertions(+), 6 deletions(-)
> 

Hi Guilherme,

Some subjective grammar nits.

> diff --git a/Documentation/admin-guide/kernel-parameters.txt b/Documentation/admin-guide/kernel-parameters.txt
> index efc52ddc6864..351730108c58 100644
> --- a/Documentation/admin-guide/kernel-parameters.txt
> +++ b/Documentation/admin-guide/kernel-parameters.txt
> @@ -913,12 +913,16 @@
>  			the parameter has no effect.
>  
>  	crash_kexec_post_notifiers
> -			Run kdump after running panic-notifiers and dumping
> -			kmsg. This only for the users who doubt kdump always
> -			succeeds in any situation.
> -			Note that this also increases risks of kdump failure,
> -			because some panic notifiers can make the crashed
> -			kernel more unstable.
> +			Only jump to kdump kernel after running the panic
> +			notifiers and dumping kmsg. This option increases the
> +			risks of a kdump failure, since some panic notifiers
> +			can make the crashed kernel more unstable. In the

nit: In the configurations -> In configurations

> +			configurations where kdump may not be reliable,
> +			running the panic notifiers can allow collecting more
> +			data on dmesg, like stack traces from other CPUS or
> +			extra data dumped by panic_print. Notice that some

nit: Notice that -> Note that

> +			code enables this option unconditionally, like

Maybe: some code enables -> some configurations enable

> +			Hyper-V, PowerPC (fadump) and AMD SEV.
>  
>  	crashkernel=size[KMG][@offset[KMG]]
>  			[KNL,EARLY] Using kexec, Linux can switch to a 'crash kernel'
> -- 
> 2.46.0
> 
> 
> _______________________________________________
> kexec mailing list
> kexec@...ts.infradead.org
> http://lists.infradead.org/mailman/listinfo/kexec
> 

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives