linux-kernel - Re: [PATCH v2] pinctrl: Simplify with dev_err

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CACRpkdYMn1FyUFrhGMx=Kq=zK28o1QX-pnJ_tKihduouML4aeg@mail.gmail.com>
Date: Mon, 2 Sep 2024 10:28:47 +0200
From: Linus Walleij <linus.walleij@...aro.org>
To: Yan Zhen <yanzhen@...o.com>
Cc: ckeepax@...nsource.cirrus.com, rf@...nsource.cirrus.com, 
	linux-sound@...r.kernel.org, patches@...nsource.cirrus.com, 
	linux-gpio@...r.kernel.org, linux-kernel@...r.kernel.org, 
	opensource.kernel@...o.com
Subject: Re: [PATCH v2] pinctrl: Simplify with dev_err_probe()

On Thu, Aug 29, 2024 at 6:48 AM Yan Zhen <yanzhen@...o.com> wrote:

> Switch to use dev_err_probe() to simplify the error path and
> unify a message template.
>
> Using this helper is totally fine even if err is known to never
> be -EPROBE_DEFER.
>
> The benefit compared to a normal dev_err() is the standardized format
> of the error code, it being emitted symbolically and the fact that
> the error code is returned which allows more compact error paths.
>
>
> Signed-off-by: Yan Zhen <yanzhen@...o.com>

Fixed up the subject and applied the patch.

Yours,
Linus Walleij