linux-kernel - Re: [PATCH] spi: zynq-qspi: Replace kzalloc with kmalloc for buffer allocation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f4c4da23-c22e-426b-8b18-f2173a3c72aa@amd.com>
Date: Mon, 2 Sep 2024 10:52:42 +0200
From: Michal Simek <michal.simek@....com>
To: Kuan-Wei Chiu <visitorckw@...il.com>, Mark Brown <broonie@...nel.org>
Cc: Ching-Chun Huang <jserv@...s.ncku.edu.tw>, linux-spi@...r.kernel.org,
 linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] spi: zynq-qspi: Replace kzalloc with kmalloc for buffer
 allocation



On 8/14/24 21:28, Kuan-Wei Chiu wrote:
> In zynq_qspi_exec_mem_op(), the temporary buffer is allocated with
> kzalloc and then immediately initialized using memset to 0xff. To
> optimize this, replace kzalloc with kmalloc, as the zeroing operation
> is redundant and unnecessary.
> 
> Signed-off-by: Kuan-Wei Chiu <visitorckw@...il.com>
> ---
> Note: Build test only.
> 
>   drivers/spi/spi-zynq-qspi.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/spi/spi-zynq-qspi.c b/drivers/spi/spi-zynq-qspi.c
> index d6325c6be3d4..b67455bda972 100644
> --- a/drivers/spi/spi-zynq-qspi.c
> +++ b/drivers/spi/spi-zynq-qspi.c
> @@ -569,7 +569,7 @@ static int zynq_qspi_exec_mem_op(struct spi_mem *mem,
>   	}
>   
>   	if (op->dummy.nbytes) {
> -		tmpbuf = kzalloc(op->dummy.nbytes, GFP_KERNEL);
> +		tmpbuf = kmalloc(op->dummy.nbytes, GFP_KERNEL);
>   		if (!tmpbuf)
>   			return -ENOMEM;
>   

Reviewed-by: Michal Simek <michal.simek@....com>

Thanks,
Michal